You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ne...@apache.org on 2013/10/31 14:04:59 UTC
svn commit: r1537475 - /subversion/branches/1.8.x/STATUS
Author: neels
Date: Thu Oct 31 13:04:58 2013
New Revision: 1537475
URL: http://svn.apache.org/r1537475
Log:
* STATUS: Nominate r1525902.
Modified:
subversion/branches/1.8.x/STATUS
Modified: subversion/branches/1.8.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.8.x/STATUS?rev=1537475&r1=1537474&r2=1537475&view=diff
==============================================================================
--- subversion/branches/1.8.x/STATUS (original)
+++ subversion/branches/1.8.x/STATUS Thu Oct 31 13:04:58 2013
@@ -210,6 +210,20 @@ Candidate changes:
+1: breser (without r1537415)
+1: rhuijben
+ * r1525902
+ Fix issues #4428, #4429: "checkout via http with external pointing at
+ redirected URL".
+ Justification:
+ Such a stupid mistake, to carefully follow the URL redirection just to
+ use the unredirected URL subsequently. Breaks externals as soon as the
+ repository URL gets redirected.
+ Notes:
+ I'd be glad to add a regression test, but I'm not entirely clear on how
+ to make our test suite model an external to a redirected URL. A testing
+ recipe is in issue #4428.
+ Votes:
+ +1: neels
+
Veto-blocked changes:
=====================
Re: svn commit: r1537475 - /subversion/branches/1.8.x/STATUS
Posted by Neels Hofmeyr <ne...@elego.de>.
"Bert Huijben" <be...@qqmail.nl>:
> > + Votes:
> > + +1: neels
>
> I'll add my +1 to this nomination, but answering your question: See
> redirect_tests.py on how to obtain a redirect url for an existing
> test repository.
duh, of course! Thanks.
...as soon as I get the time...
~Neels
RE: svn commit: r1537475 - /subversion/branches/1.8.x/STATUS
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: neels@apache.org [mailto:neels@apache.org]
> Sent: donderdag 31 oktober 2013 14:05
> To: commits@subversion.apache.org
> Subject: svn commit: r1537475 - /subversion/branches/1.8.x/STATUS
>
> Author: neels
> Date: Thu Oct 31 13:04:58 2013
> New Revision: 1537475
>
> URL: http://svn.apache.org/r1537475
> Log:
> * STATUS: Nominate r1525902.
>
> Modified:
> subversion/branches/1.8.x/STATUS
>
> Modified: subversion/branches/1.8.x/STATUS
> URL:
> http://svn.apache.org/viewvc/subversion/branches/1.8.x/STATUS?rev=1537
> 475&r1=1537474&r2=1537475&view=diff
> ==========================================================
> ====================
> --- subversion/branches/1.8.x/STATUS (original)
> +++ subversion/branches/1.8.x/STATUS Thu Oct 31 13:04:58 2013
> @@ -210,6 +210,20 @@ Candidate changes:
> +1: breser (without r1537415)
> +1: rhuijben
>
> + * r1525902
> + Fix issues #4428, #4429: "checkout via http with external pointing at
> + redirected URL".
> + Justification:
> + Such a stupid mistake, to carefully follow the URL redirection just to
> + use the unredirected URL subsequently. Breaks externals as soon as the
> + repository URL gets redirected.
> + Notes:
> + I'd be glad to add a regression test, but I'm not entirely clear on how
> + to make our test suite model an external to a redirected URL. A testing
> + recipe is in issue #4428.
> + Votes:
> + +1: neels
I'll add my +1 to this nomination, but answering your question: See redirect_tests.py on how to obtain a redirect url for an existing test repository.
Bert