You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/28 03:26:40 UTC

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2438: SOLR-14928: add exponential backoff for distributed cluster state updates

dsmiley commented on a change in pull request #2438:
URL: https://github.com/apache/lucene-solr/pull/2438#discussion_r584224056



##########
File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java
##########
@@ -111,7 +111,7 @@
       DocCollection.PER_REPLICA_STATE, null,
       ZkStateReader.PULL_REPLICAS, "0"));
 
-  protected static final Random RANDOM;
+  public static final Random RANDOM;

Review comment:
       My instinct would be to lowercase this field name because it's not really some constant.  It's rather rare in the codebase to use all-caps in other situations.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org