[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #601: Fix Parquet with special characters in field names.

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #601: Fix Parquet with special characters in field names.
URL: https://github.com/apache/incubator-iceberg/pull/601#discussion_r341736224
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java
 ##########
 @@ -347,6 +347,13 @@ static Schema copyRecord(Schema record, List<Schema.Field> newFields, String new
     return copy;
   }
 
+  public static String makeCompatibleName(String name) {
 
 Review comment:
   Nit: do you want to use this method in org.apache.iceberg.avro.TypeToSchema#struct() api? 
   Currently the code is 
   ```
   boolean isValidFieldName = AvroSchemaUtil.validAvroName(origFieldName);
   String fieldName =  isValidFieldName ? origFieldName : AvroSchemaUtil.sanitize(origFieldName);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org