[GitHub] [incubator-tvm] comaniac commented on issue #5210: [RELAY] kExternalSymbol -> kGlobalSymbol

[GitBox <gi...@apache.org>]

comaniac commented on issue #5210: [RELAY]  kExternalSymbol -> kGlobalSymbol
URL: https://github.com/apache/incubator-tvm/issues/5210#issuecomment-607497506
 
 
   Seems doable. `kExternalSymbol` is added by graph partition pass, so as long as we can make sure the build flow after graph partition pass won't mess up with `kExternalSymbol` and `kGlobalSymbol`, we should be good.
   
   I checked the flow after graph partition pass and mainly located to `compiler engine` and `customized codegen`.
   
   1. Since `compile_engine::LowerExternalFunctions` will first check if `kCompiler` is defined before retriving `kExternalSymbol`, this part should be safe.
   
   2. `customzed codegen` will only receive extenral functions, so it should not matter which symbol we use.
   
   @zhiics please double confirm if I missed anything.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services