You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "danielzhe (via GitHub)" <gi...@apache.org> on 2025/01/16 19:45:25 UTC

[PR] NO-ISSUE: Fix jbpm-quarkus-devui script for Windows [incubator-kie-tools]

danielzhe opened a new pull request, #2862:
URL: https://github.com/apache/incubator-kie-tools/pull/2862

   The script was not working in Windows because of some single quotes.
   It is working now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] NO-ISSUE: Fix `jbpm-quarkus-devui` `start` script for Windows [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2862:
URL: https://github.com/apache/incubator-kie-tools/pull/2862


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] NO-ISSUE: Fix jbpm-quarkus-devui script for Windows [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #2862:
URL: https://github.com/apache/incubator-kie-tools/pull/2862#discussion_r1919139551


##########
examples/process-compact-architecture/package.json:
##########
@@ -24,7 +24,7 @@
     "powershell": "@powershell -NoProfile -ExecutionPolicy Unrestricted -Command",
     "start": "run-script-os",
     "start:darwin:linux": "mvn quarkus:dev -DskipTests -Pdevelopment",
-    "start:win32": "mvn quarkus:dev `-DskipTests `-Pdevelopment",
+    "start:win32": "mvn quarkus:dev -DskipTests -Pdevelopment",

Review Comment:
   An alternative solution would be 
   ```suggestion
       "start:win32": "pnpm powershell mvn quarkus:dev `-DskipTests `-Pdevelopment",
   ```
   
   We usually invoke powershell to be able to use the command substitution syntax `$()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] NO-ISSUE: Fix jbpm-quarkus-devui script for Windows [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on code in PR #2862:
URL: https://github.com/apache/incubator-kie-tools/pull/2862#discussion_r1919608352


##########
examples/process-compact-architecture/package.json:
##########
@@ -24,7 +24,7 @@
     "powershell": "@powershell -NoProfile -ExecutionPolicy Unrestricted -Command",
     "start": "run-script-os",
     "start:darwin:linux": "mvn quarkus:dev -DskipTests -Pdevelopment",
-    "start:win32": "mvn quarkus:dev `-DskipTests `-Pdevelopment",
+    "start:win32": "mvn quarkus:dev -DskipTests -Pdevelopment",

Review Comment:
   +1 for `powershell` as it will be aligned with the repo
   ![image](https://github.com/user-attachments/assets/0e28ee0c-07f2-45f7-8fa5-4b3e1da2035e)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org