You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Richard Garand <ri...@garandnet.net> on 2004/04/20 01:57:37 UTC

Aborted commits and commit messages

When a commit fails for some reason, subversion prints an error like this:

svn: Your commit message was left in a temporary file:
svn:    '/home/richard/projects/cms1/svn-commit.tmp'

Doesn't it make sense to load that message during the next commit attempt 
instead of making the user to abort the commit, open the file, copy the 
message, start a new commit, and paste the message? As of version 1.0.1, I 
have never seen subversion do this.
-- 
Richard Garand  --  http://www.garandnet.net
Seen on eBay: "Praise : Complete Fraud! Took all our money and never received 
any product"

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Aborted commits and commit messages

Posted by Dimitri Papadopoulos-Orfanos <pa...@shfj.cea.fr>.
Hi,

> The following will work and I've used it myself:
> 
> svn ci -F /home/richard/projects/cms1/svn-commit.tmp

It works, but it's not necessarily easy to remember this command. At 
least it's not easy not for everyone. Consider that some Subversion 
users are not programers or and some of them don't even sit in front of 
a computer everyday...

I think that the original poister meant is that it would make life 
easier for many users if this was automated.

Now maybe such behavior belongs to a graphical user interface, not to 
the command-line interface.

--
Dimitri

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Aborted commits and commit messages

Posted by Dominic Anello <da...@danky.com>.
On 2004-04-19 19:57:37 -0600, Richard Garand wrote:
> When a commit fails for some reason, subversion prints an error like this:
> 
> svn: Your commit message was left in a temporary file:
> svn:    '/home/richard/projects/cms1/svn-commit.tmp'
> 
> Doesn't it make sense to load that message during the next commit attempt 
> instead of making the user to abort the commit, open the file, copy the 
> message, start a new commit, and paste the message? As of version 1.0.1, I 
> have never seen subversion do this.

The following will work and I've used it myself:

svn ci -F /home/richard/projects/cms1/svn-commit.tmp

-- 
Clearing my throat and gripping the lectern I smile and face my audience
Clearing his throat and smiling with his hands on the bathroom sink
    -TMBG, "'Till My Head Falls Off"

Re: Aborted commits and commit messages

Posted by Pierre THIERRY <pi...@moine-fou.org>.
> > why not just insert the contents of the 'svn-commit.tmp' file into
> > the current buffer?
> Yes, I think I remember how to read in another file in vi

:read

BTW, if I understood correctly your situation, with the attached Vim
script in ~/.vim/, you just have to run the following command:

$ EDITOR="vim -fs ~/.vim/svn-recommit.vim" svn commit

> after vi started it was hidden and exiting vi to see where it was was
> the fastest way to get it.

:!ls

Quickly,
le Moine Fou
-- 
pierre.thierry@moine-fou.org
OpenPGP 0xD9D50D8A

Re: Aborted commits and commit messages

Posted by Richard Garand <ri...@garandnet.net>.
On April 20, 2004 10:24 am, Ben Collins-Sussman wrote:
> Why are you aborting the commit and copying/pasting?
>
> If, in your 2nd commit, your $EDITOR comes up blank, why not just insert
> the contents of the 'svn-commit.tmp' file into the current buffer?  In
> emacs, it's a simple "C-X, i".  I'm sure it's just as easy to do that in
> vi or any other editor.

Yes, I think I remember how to read in another file in vi, so I could do that; 
however, working under the assumption that what I saw as the obvious thing 
would be done automatically, I didn't look at the filename; after vi started 
it was hidden and exiting vi to see where it was was the fastest way to get 
it.
-- 
Richard Garand  --  http://www.garandnet.net
The memory management on the PowerPC can be used to frighten small children.
        -- Linus Torvalds

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Aborted commits and commit messages

Posted by "Marcel Molina Jr." <ma...@vernix.org>.
On Tue, Apr 20, 2004 at 11:24:19AM -0500, Ben Collins-Sussman wrote:
> On Mon, 2004-04-19 at 20:57, Richard Garand wrote:
> > When a commit fails for some reason, subversion prints an error like this:
> > 
> > svn: Your commit message was left in a temporary file:
> > svn:    '/home/richard/projects/cms1/svn-commit.tmp'
> > 
> > Doesn't it make sense to load that message during the next commit attempt 
> > instead of making the user to abort the commit, open the file, copy the 
> > message, start a new commit, and paste the message? As of version 1.0.1, I 
> > have never seen subversion do this.
> 
> Why are you aborting the commit and copying/pasting?
> 
> If, in your 2nd commit, your $EDITOR comes up blank, why not just insert
> the contents of the 'svn-commit.tmp' file into the current buffer?  In
> emacs, it's a simple "C-X, i".  I'm sure it's just as easy to do that in
> vi or any other editor.

just to save someone a second of time, in vi it would be done like this:

:r <filename>

in command mode

marcel
-- 
Marcel Molina Jr. <ma...@vernix.org>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Aborted commits and commit messages

Posted by Brian Mathis <bm...@directedge.com>.
Ben Collins-Sussman wrote:

>On Mon, 2004-04-19 at 20:57, Richard Garand wrote:
>  
>
>>When a commit fails for some reason, subversion prints an error like this:
>>
>>svn: Your commit message was left in a temporary file:
>>svn:    '/home/richard/projects/cms1/svn-commit.tmp'
>>
>>Doesn't it make sense to load that message during the next commit attempt 
>>instead of making the user to abort the commit, open the file, copy the 
>>message, start a new commit, and paste the message? As of version 1.0.1, I 
>>have never seen subversion do this.
>>    
>>
>
>Why are you aborting the commit and copying/pasting?
>
>If, in your 2nd commit, your $EDITOR comes up blank, why not just insert
>the contents of the 'svn-commit.tmp' file into the current buffer?  In
>emacs, it's a simple "C-X, i".  I'm sure it's just as easy to do that in
>vi or any other editor.
>
>  
>

I think the point is that it doesn't really make sense to have this 
extra step.  I've certainly aborted a commit a few times, only to 
recommit, retype my log, then realize there was a .tmp file already 
there.  I can't say for certain that now that I know it's there, that I 
would even remember the next time.

Dare I say it, but reading in the tmp file log message would be a great 
UI improvement, just enough to add some nice polish.

-- 
Brian Mathis
http://directedge.com/b/


Re: Aborted commits and commit messages

Posted by Ben Collins-Sussman <su...@collab.net>.
On Mon, 2004-04-19 at 20:57, Richard Garand wrote:
> When a commit fails for some reason, subversion prints an error like this:
> 
> svn: Your commit message was left in a temporary file:
> svn:    '/home/richard/projects/cms1/svn-commit.tmp'
> 
> Doesn't it make sense to load that message during the next commit attempt 
> instead of making the user to abort the commit, open the file, copy the 
> message, start a new commit, and paste the message? As of version 1.0.1, I 
> have never seen subversion do this.

Why are you aborting the commit and copying/pasting?

If, in your 2nd commit, your $EDITOR comes up blank, why not just insert
the contents of the 'svn-commit.tmp' file into the current buffer?  In
emacs, it's a simple "C-X, i".  I'm sure it's just as easy to do that in
vi or any other editor.



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Aborted commits and commit messages

Posted by Michael W Thelen <th...@cs.utah.edu>.
* Richard Garand <ri...@garandnet.net> [2004-04-20 10:14]:
> Doesn't it make sense to load that message during the next commit attempt 
> instead of making the user to abort the commit, open the file, copy the 
> message, start a new commit, and paste the message? As of version 1.0.1, I 
> have never seen subversion do this.

If you'd like to use the contents of svn-commit.tmp as your commit message, I
think it's easier just to use the -F (--file) option, as in:

svn commit -F svn-commit.tmp

-- Mike

-- 
Michael W. Thelen
The easiest person to deceive is one's self.
                -- Edward Bulwer-Lytton, "The Disowned"