You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/14 16:46:27 UTC
[GitHub] [apisix] KishaniKandasamy opened a new pull request #4053: fix: broken link for benchmark data
KishaniKandasamy opened a new pull request #4053:
URL: https://github.com/apache/apisix/pull/4053
fix: [#310](https://github.com/apache/apisix-website/issues/310)
update FAQ with correct benchmark link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r614312462
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.
Review comment:
I will fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r614359338
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install dependencies](install-dependencies.md) document for installation.
Review comment:
I think It will work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r615056430
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.
Review comment:
No I think it will work fine without adding install-dependencies to latest/config.json as same as how to build doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r614963262
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.
Review comment:
Please solve this so that I can merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r615202954
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.
Review comment:
https://www.mkdocs.org/user-guide/writing-your-docs/#linking-to-pages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4053:
URL: https://github.com/apache/apisix/pull/4053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r614544574
##########
File path: docs/en/latest/FAQ.md
##########
@@ -35,7 +35,7 @@ In addition, APISIX has dynamic routing and hot loading of plug-ins, which is es
## What's the performance of APISIX?
-One of the goals of APISIX design and development is the highest performance in the industry. Specific test data can be found here：[benchmark](https://github.com/apache/apisix/blob/master/benchmark.md)
+One of the goals of APISIX design and development is the highest performance in the industry. Specific test data can be found here：[benchmark](https://github.com/apache/apisix/blob/master/docs/en/latest/benchmark.md)
Review comment:
We can use `[benchmark](benchmark.md)` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4053: fix: broken links in FAQ
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r613679266
##########
File path: docs/es/latest/FAQ.md
##########
@@ -57,7 +57,7 @@ Para el centro de la configuración, la configuración del almacenamiento es sol
4. Notificación de cambios
5. Alto rendimiento
-Más información en [Por qué etcd](https://github.com/etcd-io/etcd/blob/master/Documentation/learning/why.md#comparison-chart).
+Más información en [Por qué etcd](https://github.com/etcd-io/website/blob/master/content/docs/v3.4/learning/why.md#comparison-chart).
Review comment:
Ditto.
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -58,7 +58,7 @@ APISIX 是当前性能最好的 API 网关，单核 QPS 达到 2.3 万，平均
4. 变化通知
5. 高性能
-APISIX 需要一个配置中心，上面提到的很多功能是传统关系型数据库和 KV 数据库是无法提供的。与 etcd 同类软件还有 Consul、ZooKeeper 等，更详细比较可以参考这里：[etcd why](https://etcd.io/docs/v3.4.0/learning/why/)，在将来也许会支持其他配置存储方案。
+APISIX 需要一个配置中心，上面提到的很多功能是传统关系型数据库和 KV 数据库是无法提供的。与 etcd 同类软件还有 Consul、ZooKeeper 等，更详细比较可以参考这里：[etcd why](https://github.com/etcd-io/website/blob/master/content/docs/v3.4/learning/why.md#comparison-chart)，在将来也许会支持其他配置存储方案。
Review comment:
Ditto.
##########
File path: docs/en/latest/FAQ.md
##########
@@ -59,7 +59,7 @@ For the configuration center, configuration storage is only the most basic funct
4. Change Notification
5. High Performance
-See more [etcd why](https://github.com/etcd-io/etcd/blob/master/Documentation/learning/why.md#comparison-chart).
+See more [etcd why](https://github.com/etcd-io/website/blob/master/content/docs/v3.4/learning/why.md#comparison-chart).
Review comment:
I think we can use the `next` version doc.
https://github.com/etcd-io/website/blob/master/content/docs/next/learning/why.md#comparison-chart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r615336073
##########
File path: docs/en/latest/config.json
##########
@@ -193,6 +193,10 @@
"type": "doc",
"id": "benchmark"
},
+ {
+ "type": "doc",
+ "id": "install-dependencies"
Review comment:
Need to do the same thing with `docs/zh/latest/config.json`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r614917029
##########
File path: docs/en/latest/FAQ.md
##########
@@ -35,7 +35,7 @@ In addition, APISIX has dynamic routing and hot loading of plug-ins, which is es
## What's the performance of APISIX?
-One of the goals of APISIX design and development is the highest performance in the industry. Specific test data can be found here：[benchmark](https://github.com/apache/apisix/blob/master/benchmark.md)
+One of the goals of APISIX design and development is the highest performance in the industry. Specific test data can be found here：[benchmark](https://github.com/apache/apisix/blob/master/docs/en/latest/benchmark.md)
Review comment:
yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r613820732
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.
Review comment:
just checked, yea, we should
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r614312462
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.
Review comment:
Yes . I will fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r615059923
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.
Review comment:
Earlier, the issue we had, is install-dependencies.**_md_**(install-dependencies.md) instead of install dependencies(install-dependencies.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r615056430
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.
Review comment:
No I think it will work fine without adding install-dependencies to latest/config.json🤔 ( as same as how to build doc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r615136954
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.
Review comment:
If we don't add them to config.json, we could render it, but without the left sidebar actually 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r613798281
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.
Review comment:
Look like we need to add `install-dependencies` to `latest/config.json`?
CC @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4053: docs: fix broken links in FAQ
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4053:
URL: https://github.com/apache/apisix/pull/4053#discussion_r615247772
##########
File path: docs/en/latest/FAQ.md
##########
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.
Review comment:
We mean the left sidebar of our website. The `config.json` is the index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org