You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/04 21:30:28 UTC

[GitHub] [netbeans] matthiasblaesing opened a new pull request #1843: Allow ".external" files to define message digest values for download verification

matthiasblaesing opened a new pull request #1843: Allow ".external" files to define message digest values for download verification
URL: https://github.com/apache/netbeans/pull/1843
 
 
   This formalises the format of the ".external" files and introduces a new
   content line, that allows specification of a message digest algorithm
   and the digest value, that results from applying the message digest to
   the referenced URL.
   
   At download time the message digest value is calculated from the
   downloaded data and compared. If it does not match, an exception is
   raised.
   
   Multiple message digest can be provided and message digests with
   unsupported algorithms are ignored. This allows for future evolution,
   when new algorithms are added and older ones are phased out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] emilianbold commented on issue #1843: Allow ".external" files to define message digest values for download verification

Posted by GitBox <gi...@apache.org>.
emilianbold commented on issue #1843: Allow ".external" files to define message digest values for download verification
URL: https://github.com/apache/netbeans/pull/1843#issuecomment-570822929
 
 
   PS: Now you might as well revisit PR #1260 and see how to add the same (SHA 256/512) message digest algorithm and the digest value to external binaries.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] jlahoda commented on issue #1843: Allow ".external" files to define message digest values for download verification

Posted by GitBox <gi...@apache.org>.
jlahoda commented on issue #1843: Allow ".external" files to define message digest values for download verification
URL: https://github.com/apache/netbeans/pull/1843#issuecomment-570823681
 
 
   Sounds great! (Eventually, we could hopefully get rid of actually having the CRC there - that is very inconvenient to get.)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] emilianbold commented on issue #1843: Allow ".external" files to define message digest values for download verification

Posted by GitBox <gi...@apache.org>.
emilianbold commented on issue #1843: Allow ".external" files to define message digest values for download verification
URL: https://github.com/apache/netbeans/pull/1843#issuecomment-570822579
 
 
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing merged pull request #1843: Allow ".external" files to define message digest values for download verification

Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #1843: Allow ".external" files to define message digest values for download verification
URL: https://github.com/apache/netbeans/pull/1843
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] jlahoda commented on issue #1843: Allow ".external" files to define message digest values for download verification

Posted by GitBox <gi...@apache.org>.
jlahoda commented on issue #1843: Allow ".external" files to define message digest values for download verification
URL: https://github.com/apache/netbeans/pull/1843#issuecomment-571793193
 
 
   @matthiasblaesing - sure I was just talking about a possible future improvements. I can even look at that myself, if you prefer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on issue #1843: Allow ".external" files to define message digest values for download verification

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1843: Allow ".external" files to define message digest values for download verification
URL: https://github.com/apache/netbeans/pull/1843#issuecomment-571782025
 
 
   Thank you for the review - I'll merge as is and will revisit later. Removing CRC will be more work, as it is used internally and not only as checksum.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] emilianbold commented on issue #1843: Allow ".external" files to define message digest values for download verification

Posted by GitBox <gi...@apache.org>.
emilianbold commented on issue #1843: Allow ".external" files to define message digest values for download verification
URL: https://github.com/apache/netbeans/pull/1843#issuecomment-570823986
 
 
   Yes, ideally CRC would be optional if another digest is available (since any of them would be better).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists