[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #216: reject future writes if there is no disk spaces any more

[GitBox <gi...@apache.org>]

jixuan1989 commented on a change in pull request #216: reject future writes if there is no disk spaces any more
URL: https://github.com/apache/incubator-iotdb/pull/216#discussion_r298873342
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/engine/filenodeV2/FileNodeManagerV2.java
 ##########
 @@ -200,22 +215,30 @@ private void writeLog(TSRecord tsRecord, boolean isMonitor, WriteLogNode logNode
   /**
    * update data.
    */
-  public void update(String deviceId, String measurementId, long startTime, long endTime,
+  public boolean update(String deviceId, String measurementId, long startTime, long endTime,
       TSDataType type, String v) {
+    if (rejectWrite) {
+      return false;
+    }
     // TODO
+    return false;
   }
 
   /**
    * delete data.
    */
-  public void delete(String deviceId, String measurementId, long timestamp)
+  public boolean delete(String deviceId, String measurementId, long timestamp)
       throws FileNodeManagerException {
+    if (rejectWrite) {
+      return false;
 
 Review comment:
   > should we block `delete` if disk space is not enough ?
   
   because delete is in the lazy mode... It does not delete data on disk immediately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services