You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/10 04:06:24 UTC

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #760: feat: support specifying APISIX path to generate json schema

nic-chen opened a new pull request #760:
URL: https://github.com/apache/apisix-dashboard/pull/760


   support specifying APISIX path to generate json schema


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #760: feat: support specifying APISIX path to generate json schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #760:
URL: https://github.com/apache/apisix-dashboard/pull/760#issuecomment-724523302


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`v2.0@9d4b371`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/760/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##             v2.0     #760   +/-   ##
   =======================================
     Coverage        ?   42.91%           
   =======================================
     Files           ?       18           
     Lines           ?     1249           
     Branches        ?        0           
   =======================================
     Hits            ?      536           
     Misses          ?      624           
     Partials        ?       89           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=footer). Last update [9d4b371...b7aa691](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #760: feat: support specifying APISIX path to generate json schema

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #760:
URL: https://github.com/apache/apisix-dashboard/pull/760#discussion_r520307454



##########
File path: docs/develop.zh-CN.md
##########
@@ -47,7 +47,11 @@ $ yarn start
 
 ### 同步 jsonschema
 
-从 Apache APISIX 同步 jsonschema ,需要预安装 `Lua` 5.1+ 和 `zip` ,并执行命令 `api/build-tools/schema-sync.sh $version`。
+从 Apache APISIX 同步 jsonschema ,需要预安装 `Lua` 5.1+ 和 `zip` ,并执行命令 
+
+```sh
+api/build-tools/schema-sync.sh $version

Review comment:
       $




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on pull request #760: feat: support specifying APISIX path to generate json schema

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #760:
URL: https://github.com/apache/apisix-dashboard/pull/760#issuecomment-724436402


   doc will be updated soon


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io commented on pull request #760: feat: support specifying APISIX path to generate json schema

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #760:
URL: https://github.com/apache/apisix-dashboard/pull/760#issuecomment-724523302


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`v2.0@9d4b371`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/760/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##             v2.0     #760   +/-   ##
   =======================================
     Coverage        ?   42.91%           
   =======================================
     Files           ?       18           
     Lines           ?     1249           
     Branches        ?        0           
   =======================================
     Hits            ?      536           
     Misses          ?      624           
     Partials        ?       89           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=footer). Last update [9d4b371...6efb728](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #760: feat: support specifying APISIX path to generate json schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #760:
URL: https://github.com/apache/apisix-dashboard/pull/760#issuecomment-724523302


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`v2.0@9d4b371`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/760/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##             v2.0     #760   +/-   ##
   =======================================
     Coverage        ?   42.91%           
   =======================================
     Files           ?       18           
     Lines           ?     1249           
     Branches        ?        0           
   =======================================
     Hits            ?      536           
     Misses          ?      624           
     Partials        ?       89           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=footer). Last update [9d4b371...d7e6ac5](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen closed pull request #760: feat: support specifying APISIX path to generate json schema

Posted by GitBox <gi...@apache.org>.
nic-chen closed pull request #760:
URL: https://github.com/apache/apisix-dashboard/pull/760


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #760: feat: support specifying APISIX path to generate json schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #760:
URL: https://github.com/apache/apisix-dashboard/pull/760#issuecomment-724523302


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`v2.0@9d4b371`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/760/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##             v2.0     #760   +/-   ##
   =======================================
     Coverage        ?   42.91%           
   =======================================
     Files           ?       18           
     Lines           ?     1249           
     Branches        ?        0           
   =======================================
     Hits            ?      536           
     Misses          ?      624           
     Partials        ?       89           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=footer). Last update [9d4b371...6efb728](https://codecov.io/gh/apache/apisix-dashboard/pull/760?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org