[GitHub] rdhabalia commented on a change in pull request #3486: [pulsar-broker] separate broker-client config to allow-insecure-cnx for broker replication

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #3486: [pulsar-broker] separate broker-client config to allow-insecure-cnx for broker replication
URL: https://github.com/apache/pulsar/pull/3486#discussion_r252502081
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 ##########
 @@ -563,7 +563,7 @@ public PulsarClient getReplicationClient(String cluster) {
                                     : data.getServiceUrlTls())
                             .enableTls(true)
                             .tlsTrustCertsFilePath(pulsar.getConfiguration().getBrokerClientTrustCertsFilePath())
-                            .allowTlsInsecureConnection(pulsar.getConfiguration().isTlsAllowInsecureConnection());
+                            .allowTlsInsecureConnection(pulsar.getConfiguration().isBrokerClientTlsAllowInsecureConnection());
 
 Review comment:
   hmm.. `brokerClientTlsAllowInsecureConnection` is a boolean value and if it's not present into the config file then broker will read it as false. also, sometimes user assumes that broker will pick default value if not present into config-file and in this case if broker falls to `tlsAllowInsecureConnection` then it will create unexpected behavior. Also, I don't see it a breaking change for future release so, we might just stay with this change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services