You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/19 13:40:40 UTC

[GitHub] [kafka] viktorsomogyi opened a new pull request, #12180: KAFKA-13917: Avoid calling lookupCoordinator() in tight loop

viktorsomogyi opened a new pull request, #12180:
URL: https://github.com/apache/kafka/pull/12180

   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] viktorsomogyi commented on pull request #12180: KAFKA-13917: Avoid calling lookupCoordinator() in tight loop

Posted by GitBox <gi...@apache.org>.
viktorsomogyi commented on PR #12180:
URL: https://github.com/apache/kafka/pull/12180#issuecomment-1132983718

   @mimaison would you please review this short change if you get some time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #12180: KAFKA-13917: Avoid calling lookupCoordinator() in tight loop

Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12180:
URL: https://github.com/apache/kafka/pull/12180#issuecomment-1151912237

   Failed tests are unrelated:
   ```
       Build / JDK 11 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testConfigurationOperations()
       Build / JDK 17 and Scala 2.13 / kafka.admin.TopicCommandIntegrationTest.testDescribeAtMinIsrPartitions(String).quorum=kraft
       Build / JDK 17 and Scala 2.13 / kafka.controller.ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] viktorsomogyi commented on pull request #12180: KAFKA-13917: Avoid calling lookupCoordinator() in tight loop

Posted by GitBox <gi...@apache.org>.
viktorsomogyi commented on PR #12180:
URL: https://github.com/apache/kafka/pull/12180#issuecomment-1148387148

   @hachikuji would you please review this small PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon merged pull request #12180: KAFKA-13917: Avoid calling lookupCoordinator() in tight loop

Posted by GitBox <gi...@apache.org>.
showuon merged PR #12180:
URL: https://github.com/apache/kafka/pull/12180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #12180: KAFKA-13917: Avoid calling lookupCoordinator() in tight loop

Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12180:
URL: https://github.com/apache/kafka/pull/12180#issuecomment-1152839740

   +1 to backport this change to 3.2. Let me know if necessary. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #12180: KAFKA-13917: Avoid calling lookupCoordinator() in tight loop

Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12180:
URL: https://github.com/apache/kafka/pull/12180#issuecomment-1152528310

   Do we need to backport this? Also cc @guozhangwang @dajac since this code has gone through a few iterations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org