You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "James Carman (JIRA)" <ji...@apache.org> on 2008/02/19 04:58:34 UTC
[jira] Created: (WICKET-1358) Make Application Class More Bean-ish
Make Application Class More Bean-ish
------------------------------------
Key: WICKET-1358
URL: https://issues.apache.org/jira/browse/WICKET-1358
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.1
Reporter: James Carman
The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1358) Make Application Class More Bean-ish
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner updated WICKET-1358:
------------------------------------
Fix Version/s: 1.5-M1
Assignee: Johan Compagner
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Assignee: Johan Compagner
> Fix For: 1.5-M1
>
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1358) Make Application Class More
Bean-ish
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570538#action_12570538 ]
James Carman commented on WICKET-1358:
--------------------------------------
Wait, you guys can't all go on vacation at the same time! What happens if there's some freak accident!?!? Who's going to maintain Wicket!?!?! ;) Have fun! This will be waiting when you get back. No rush.
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1358) Make Application Class More Bean-ish
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated WICKET-1358:
---------------------------------
Attachment: (was: WICKET-1358.patch)
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1358) Make Application Class More Bean-ish
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated WICKET-1358:
---------------------------------
Attachment: WICKET-1358.patch
Here's what I have in mind. So far, I've only implemented ApplicationSettings, DebugSettings, and ExceptionSettings, but you'll get the idea of what I'm wanting to do. I don't want to the rest if you guys don't like the idea in the first place (it takes a bit of time to do this). If you like the idea, let me know and I'll finish it up and attach a patch. Thanks.
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1358) Make Application Class More Bean-ish
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1358:
----------------------------------
Fix Version/s: 1.5-M2
(was: 1.5-M1)
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Assignee: Johan Compagner
> Fix For: 1.5-M2
>
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1358) Make Application Class More
Bean-ish
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597766#action_12597766 ]
James Carman commented on WICKET-1358:
--------------------------------------
Any chance this could make it into one of the 1.4-m* releases or do we think this definitely needs to wait for 1.5?
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Assignee: Johan Compagner
> Fix For: 1.5-M1
>
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1358) Make Application Class More Bean-ish
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated WICKET-1358:
---------------------------------
Attachment: WICKET-1358.patch
Here's the full patch. All test cases pass with this. I had to modify the existing test case for application settings so that it tested against the new Default* flavors of the different interfaces. I hope you guys like it. I think it makes it a bit cleaner (and it allows me to do what I want ;).
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1358) Make Application Class More Bean-ish
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-1358:
-------------------------------------
Fix Version/s: (was: 1.5-M3)
1.5-M4
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Assignee: Johan Compagner
> Fix For: 1.5-M4
>
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1358) Make Application Class More
Bean-ish
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570533#action_12570533 ]
Igor Vaynberg commented on WICKET-1358:
---------------------------------------
a lot of core devs will be on a mini vacation in thailand for the next couple of weeks so we wont be able to get to this for a whle. just a heads up. ping the list again in a couple of weeks.
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1358) Make Application Class More
Bean-ish
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576777#action_12576777 ]
Johan Compagner commented on WICKET-1358:
-----------------------------------------
i think that change is fine but not for 1.3.x
lets do something like that for 1.4
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1358) Make Application Class More Bean-ish
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1358:
----------------------------------
Fix Version/s: 1.5-M3
(was: 1.5-M2)
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Assignee: Johan Compagner
> Fix For: 1.5-M3
>
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1358) Make Application Class More
Bean-ish
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576779#action_12576779 ]
James Carman commented on WICKET-1358:
--------------------------------------
Hey, no worries. This is your baby. I'm just an admirer! :) I'm really diggin' this Wicket stuff! Thanks for considering the patch.
> Make Application Class More Bean-ish
> ------------------------------------
>
> Key: WICKET-1358
> URL: https://issues.apache.org/jira/browse/WICKET-1358
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: James Carman
> Attachments: WICKET-1358.patch
>
>
> The Application class has getters for properties like applicationSettings and securitySettings. Couldn't we make those properties writable also? I realize that the internal implementation might have to change a bit. Currently, the Settings class implements all of those interfaces and it uses a single instance of Settings by default. The reason that I want this is so that I can set up my Application object in Spring and access it via wicket-spring. The current implementation of Application doesn't facilitate the "set up" part very well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.