You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Vincent Bernat <vi...@exoscale.ch> on 2014/12/05 23:23:36 UTC
Re: Review Request 23991: CLOUDSTACK-7195: log wide exceptions in
security_group.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23991/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 10:23 p.m.)
Review request for cloudstack and Pierre-Luc Dion.
Bugs: CLOUDSTACK-7195
https://issues.apache.org/jira/browse/CLOUDSTACK-7195
Repository: cloudstack-git
Description
-------
Some try/except in security_group.py catch a lot of exceptions. There
was already one fixed in CLOUDSTACK-1052. Here is another one. We use
logging.exception() to log those exceptions.
Diffs
-----
scripts/vm/network/security_group.py 704b27982021
Diff: https://reviews.apache.org/r/23991/diff/
Testing
-------
Thanks,
Vincent Bernat
Re: Review Request 23991: CLOUDSTACK-7195: log wide exceptions in
security_group.py
Posted by Pierre-Luc Dion <pd...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23991/#review64097
-----------------------------------------------------------
Ship it!
commited into master.
- Pierre-Luc Dion
On Dec. 5, 2014, 10:23 p.m., Vincent Bernat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23991/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 10:23 p.m.)
>
>
> Review request for cloudstack and Pierre-Luc Dion.
>
>
> Bugs: CLOUDSTACK-7195
> https://issues.apache.org/jira/browse/CLOUDSTACK-7195
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some try/except in security_group.py catch a lot of exceptions. There
> was already one fixed in CLOUDSTACK-1052. Here is another one. We use
> logging.exception() to log those exceptions.
>
>
> Diffs
> -----
>
> scripts/vm/network/security_group.py 704b27982021
>
> Diff: https://reviews.apache.org/r/23991/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vincent Bernat
>
>