You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/06/03 04:23:30 UTC

Review Request 22173: Views: ViewResourceHandler should allow Request Type in handleRequest

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22173/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Sid Wagle.


Bugs: AMBARI-5996
    https://issues.apache.org/jira/browse/AMBARI-5996


Repository: ambari


Description
-------

Currently managed resources using ViewResourceHandler.handleRequest are limited to GET.  Should also support POST, PUT and DELETE.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewSubResourceService.java d5434ea 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewSubResourceServiceTest.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/ViewResourceHandler.java 22ed0f1 

Diff: https://reviews.apache.org/r/22173/diff/


Testing
-------

New unit tests ... all existing tests pass ...

Results :

Tests run: 1647, Failures: 0, Errors: 0, Skipped: 13

...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:18.513s
[INFO] Finished at: Mon Jun 02 22:13:30 EDT 2014
[INFO] Final Memory: 36M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Re: Review Request 22173: Views: ViewResourceHandler should allow Request Type in handleRequest

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22173/#review44617
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On June 2, 2014, 10:23 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22173/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 10:23 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sid Wagle.
> 
> 
> Bugs: AMBARI-5996
>     https://issues.apache.org/jira/browse/AMBARI-5996
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently managed resources using ViewResourceHandler.handleRequest are limited to GET.  Should also support POST, PUT and DELETE.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewSubResourceService.java d5434ea 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewSubResourceServiceTest.java PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewResourceHandler.java 22ed0f1 
> 
> Diff: https://reviews.apache.org/r/22173/diff/
> 
> 
> Testing
> -------
> 
> New unit tests ... all existing tests pass ...
> 
> Results :
> 
> Tests run: 1647, Failures: 0, Errors: 0, Skipped: 13
> 
> ...
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:18.513s
> [INFO] Finished at: Mon Jun 02 22:13:30 EDT 2014
> [INFO] Final Memory: 36M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>