[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4410: [TE] Add Merger after metric grouper; other minor clean up

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4410: [TE] Add Merger after metric grouper; other minor clean up
URL: https://github.com/apache/incubator-pinot/pull/4410#discussion_r301747639
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/DetectionAlertTaskFactory.java
 ##########
 @@ -91,7 +91,7 @@ public DetectionAlertFilter loadAlertFilter(DetectionAlertConfigDTO alertConfig,
     if (alertSchemes == null || alertSchemes.isEmpty()) {
       Map<String, Object> emailScheme = new HashMap<>();
       emailScheme.put("className", DEFAULT_ALERT_SCHEME);
-      alertSchemes = Collections.singletonMap("EmailScheme", emailScheme);
+      alertSchemes = Collections.singletonMap("emailScheme", emailScheme);
 
 Review comment:
   make the "emailScheme" a static final constant?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org