You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2013/10/03 03:24:15 UTC
Review Request 14456: SENTRY-26: Separate sentry-core to hive specific and
non-specific packages
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14456/
-----------------------------------------------------------
Review request for sentry, Brock Noland and Shreepadma Venugopalan.
Bugs: SENTRY-26
https://issues.apache.org/jira/browse/SENTRY-26
Repository: sentry
Description
-------
Separated core into core-common and core-db, similar to SENTRY-17.
Highlights:
- Authorizable and Action become interfaces actually implemented via DBAuthorizable and DBAction
- There was only one instance of "getAuthzType()" being called from a common (non-db-specific) implementation, in ResourceAuthorizationProvider. The usage is "getAuthzType().getName()". To support this I added another function to Authorizable, "getTypeName"
I think the rest is fairly straightforward
Diffs
-----
pom.xml 439ce32
sentry-binding/sentry-binding-hive/pom.xml 5c3e17a
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 28b192f
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingPreExecHook.java 28812c5
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContext.java a57c510
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContextImpl.java e2142df
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java 8ecb41b
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivileges.java 2c480ef
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java b7340a2
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java d3d44d2
sentry-core/pom.xml 6afdd4a
sentry-core/sentry-core-common/pom.xml PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Authorizable.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizationProvider.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/NoAuthorizationProvider.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Subject.java PRE-CREATION
sentry-core/sentry-core-db/pom.xml PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/AccessConstants.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/AccessURI.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/DBAction.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/DBAuthorizable.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Database.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Server.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/ServerResource.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Table.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/TableOrView.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/View.java PRE-CREATION
sentry-core/sentry-core-db/src/test/java/org/apache/sentry/core/db/TestURI.java PRE-CREATION
sentry-core/src/main/java/org/apache/sentry/core/AccessConstants.java 7551a1d
sentry-core/src/main/java/org/apache/sentry/core/AccessURI.java e6d817e
sentry-core/src/main/java/org/apache/sentry/core/Action.java 94e1984
sentry-core/src/main/java/org/apache/sentry/core/Authorizable.java 2849a9f
sentry-core/src/main/java/org/apache/sentry/core/AuthorizationProvider.java c026fce
sentry-core/src/main/java/org/apache/sentry/core/Database.java 169057d
sentry-core/src/main/java/org/apache/sentry/core/NoAuthorizationProvider.java a0a6201
sentry-core/src/main/java/org/apache/sentry/core/Server.java caed9a9
sentry-core/src/main/java/org/apache/sentry/core/ServerResource.java 91334dc
sentry-core/src/main/java/org/apache/sentry/core/Subject.java fa5cd6e
sentry-core/src/main/java/org/apache/sentry/core/Table.java 9053d9a
sentry-core/src/main/java/org/apache/sentry/core/TableOrView.java d6f8837
sentry-core/src/main/java/org/apache/sentry/core/View.java 471a09c
sentry-core/src/test/java/org/apache/sentry/core/TestURI.java 5507285
sentry-dist/pom.xml 8fc489b
sentry-dist/src/main/assembly/src.xml af6dfa8
sentry-provider/sentry-provider-file/pom.xml 85bb23b
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyEngine.java 954e1d5
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/ResourceAuthorizationProvider.java f22fccd
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimplePolicyParser.java f6b87e0
sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/AbstractTestSimplePolicyEngine.java 5388b0f
sentry-provider/sentry-provider-policy-db/pom.xml ca6f6f9
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/AbstractDBRoleValidator.java d386d59
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBAuthorizables.java 089e6de
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBRoles.java 499d988
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBWildcardPermission.java 17f5a76
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseMustMatch.java db9d60c
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseRequiredInRole.java f8ab954
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServerNameMustMatch.java ab26266
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServersAllIsInvalid.java 7b56324
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/SimpleDBPolicyEngine.java 7224f60
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBAuthorizables.java 347a2c2
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBWildcardPermission.java 71474b3
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestPolicyParsingNegative.java edb715e
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderGeneralCases.java 32ade2b
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderSpecialCases.java 161067b
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestSimpleDBPolicyEngineDFS.java faf4131
sentry-tests/sentry-tests-hive/pom.xml a9d913f
Diff: https://reviews.apache.org/r/14456/diff/
Testing
-------
Ran the entire test suite.
Thanks,
Gregory Chanan
Re: Review Request 14456: SENTRY-26: Separate sentry-core to hive specific
and non-specific packages
Posted by Brock Noland <br...@cloudera.com>.
> On Oct. 3, 2013, 6:13 p.m., Brock Noland wrote:
> > sentry-tests/sentry-tests-hive/pom.xml, line 51
> > <https://reviews.apache.org/r/14456/diff/1/?file=360810#file360810line51>
> >
> > I am not as familiar with these poms as of late. Why are deleting this entry?
>
> Gregory Chanan wrote:
> I just went over the sentry-core dependencies to figure out if they needed to be sentry-core-common and/or sentry-core-hive. But in this module, I couldn't find any use of sentry-core classes so I just removed the dependency.
Ok makes sense
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14456/#review26652
-----------------------------------------------------------
On Oct. 3, 2013, 1:24 a.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14456/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2013, 1:24 a.m.)
>
>
> Review request for sentry, Brock Noland and Shreepadma Venugopalan.
>
>
> Bugs: SENTRY-26
> https://issues.apache.org/jira/browse/SENTRY-26
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Separated core into core-common and core-db, similar to SENTRY-17.
>
> Highlights:
> - Authorizable and Action become interfaces actually implemented via DBAuthorizable and DBAction
> - There was only one instance of "getAuthzType()" being called from a common (non-db-specific) implementation, in ResourceAuthorizationProvider. The usage is "getAuthzType().getName()". To support this I added another function to Authorizable, "getTypeName"
>
> I think the rest is fairly straightforward
>
>
> Diffs
> -----
>
> pom.xml 439ce32
> sentry-binding/sentry-binding-hive/pom.xml 5c3e17a
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 28b192f
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingPreExecHook.java 28812c5
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContext.java a57c510
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContextImpl.java e2142df
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java 8ecb41b
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivileges.java 2c480ef
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java b7340a2
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java d3d44d2
> sentry-core/pom.xml 6afdd4a
> sentry-core/sentry-core-common/pom.xml PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Authorizable.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizationProvider.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/NoAuthorizationProvider.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Subject.java PRE-CREATION
> sentry-core/sentry-core-db/pom.xml PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/AccessConstants.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/AccessURI.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/DBAction.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/DBAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Database.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Server.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/ServerResource.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Table.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/TableOrView.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/View.java PRE-CREATION
> sentry-core/sentry-core-db/src/test/java/org/apache/sentry/core/db/TestURI.java PRE-CREATION
> sentry-core/src/main/java/org/apache/sentry/core/AccessConstants.java 7551a1d
> sentry-core/src/main/java/org/apache/sentry/core/AccessURI.java e6d817e
> sentry-core/src/main/java/org/apache/sentry/core/Action.java 94e1984
> sentry-core/src/main/java/org/apache/sentry/core/Authorizable.java 2849a9f
> sentry-core/src/main/java/org/apache/sentry/core/AuthorizationProvider.java c026fce
> sentry-core/src/main/java/org/apache/sentry/core/Database.java 169057d
> sentry-core/src/main/java/org/apache/sentry/core/NoAuthorizationProvider.java a0a6201
> sentry-core/src/main/java/org/apache/sentry/core/Server.java caed9a9
> sentry-core/src/main/java/org/apache/sentry/core/ServerResource.java 91334dc
> sentry-core/src/main/java/org/apache/sentry/core/Subject.java fa5cd6e
> sentry-core/src/main/java/org/apache/sentry/core/Table.java 9053d9a
> sentry-core/src/main/java/org/apache/sentry/core/TableOrView.java d6f8837
> sentry-core/src/main/java/org/apache/sentry/core/View.java 471a09c
> sentry-core/src/test/java/org/apache/sentry/core/TestURI.java 5507285
> sentry-dist/pom.xml 8fc489b
> sentry-dist/src/main/assembly/src.xml af6dfa8
> sentry-provider/sentry-provider-file/pom.xml 85bb23b
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyEngine.java 954e1d5
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/ResourceAuthorizationProvider.java f22fccd
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimplePolicyParser.java f6b87e0
> sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/AbstractTestSimplePolicyEngine.java 5388b0f
> sentry-provider/sentry-provider-policy-db/pom.xml ca6f6f9
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/AbstractDBRoleValidator.java d386d59
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBAuthorizables.java 089e6de
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBRoles.java 499d988
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBWildcardPermission.java 17f5a76
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseMustMatch.java db9d60c
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseRequiredInRole.java f8ab954
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServerNameMustMatch.java ab26266
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServersAllIsInvalid.java 7b56324
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/SimpleDBPolicyEngine.java 7224f60
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBAuthorizables.java 347a2c2
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBWildcardPermission.java 71474b3
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestPolicyParsingNegative.java edb715e
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderGeneralCases.java 32ade2b
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderSpecialCases.java 161067b
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestSimpleDBPolicyEngineDFS.java faf4131
> sentry-tests/sentry-tests-hive/pom.xml a9d913f
>
> Diff: https://reviews.apache.org/r/14456/diff/
>
>
> Testing
> -------
>
> Ran the entire test suite.
>
>
> Thanks,
>
> Gregory Chanan
>
>
Re: Review Request 14456: SENTRY-26: Separate sentry-core to hive specific
and non-specific packages
Posted by Gregory Chanan <gc...@cloudera.com>.
> On Oct. 3, 2013, 6:13 p.m., Brock Noland wrote:
> > sentry-tests/sentry-tests-hive/pom.xml, line 51
> > <https://reviews.apache.org/r/14456/diff/1/?file=360810#file360810line51>
> >
> > I am not as familiar with these poms as of late. Why are deleting this entry?
I just went over the sentry-core dependencies to figure out if they needed to be sentry-core-common and/or sentry-core-hive. But in this module, I couldn't find any use of sentry-core classes so I just removed the dependency.
- Gregory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14456/#review26652
-----------------------------------------------------------
On Oct. 3, 2013, 1:24 a.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14456/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2013, 1:24 a.m.)
>
>
> Review request for sentry, Brock Noland and Shreepadma Venugopalan.
>
>
> Bugs: SENTRY-26
> https://issues.apache.org/jira/browse/SENTRY-26
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Separated core into core-common and core-db, similar to SENTRY-17.
>
> Highlights:
> - Authorizable and Action become interfaces actually implemented via DBAuthorizable and DBAction
> - There was only one instance of "getAuthzType()" being called from a common (non-db-specific) implementation, in ResourceAuthorizationProvider. The usage is "getAuthzType().getName()". To support this I added another function to Authorizable, "getTypeName"
>
> I think the rest is fairly straightforward
>
>
> Diffs
> -----
>
> pom.xml 439ce32
> sentry-binding/sentry-binding-hive/pom.xml 5c3e17a
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 28b192f
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingPreExecHook.java 28812c5
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContext.java a57c510
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContextImpl.java e2142df
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java 8ecb41b
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivileges.java 2c480ef
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java b7340a2
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java d3d44d2
> sentry-core/pom.xml 6afdd4a
> sentry-core/sentry-core-common/pom.xml PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Authorizable.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizationProvider.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/NoAuthorizationProvider.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Subject.java PRE-CREATION
> sentry-core/sentry-core-db/pom.xml PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/AccessConstants.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/AccessURI.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/DBAction.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/DBAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Database.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Server.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/ServerResource.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Table.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/TableOrView.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/View.java PRE-CREATION
> sentry-core/sentry-core-db/src/test/java/org/apache/sentry/core/db/TestURI.java PRE-CREATION
> sentry-core/src/main/java/org/apache/sentry/core/AccessConstants.java 7551a1d
> sentry-core/src/main/java/org/apache/sentry/core/AccessURI.java e6d817e
> sentry-core/src/main/java/org/apache/sentry/core/Action.java 94e1984
> sentry-core/src/main/java/org/apache/sentry/core/Authorizable.java 2849a9f
> sentry-core/src/main/java/org/apache/sentry/core/AuthorizationProvider.java c026fce
> sentry-core/src/main/java/org/apache/sentry/core/Database.java 169057d
> sentry-core/src/main/java/org/apache/sentry/core/NoAuthorizationProvider.java a0a6201
> sentry-core/src/main/java/org/apache/sentry/core/Server.java caed9a9
> sentry-core/src/main/java/org/apache/sentry/core/ServerResource.java 91334dc
> sentry-core/src/main/java/org/apache/sentry/core/Subject.java fa5cd6e
> sentry-core/src/main/java/org/apache/sentry/core/Table.java 9053d9a
> sentry-core/src/main/java/org/apache/sentry/core/TableOrView.java d6f8837
> sentry-core/src/main/java/org/apache/sentry/core/View.java 471a09c
> sentry-core/src/test/java/org/apache/sentry/core/TestURI.java 5507285
> sentry-dist/pom.xml 8fc489b
> sentry-dist/src/main/assembly/src.xml af6dfa8
> sentry-provider/sentry-provider-file/pom.xml 85bb23b
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyEngine.java 954e1d5
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/ResourceAuthorizationProvider.java f22fccd
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimplePolicyParser.java f6b87e0
> sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/AbstractTestSimplePolicyEngine.java 5388b0f
> sentry-provider/sentry-provider-policy-db/pom.xml ca6f6f9
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/AbstractDBRoleValidator.java d386d59
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBAuthorizables.java 089e6de
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBRoles.java 499d988
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBWildcardPermission.java 17f5a76
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseMustMatch.java db9d60c
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseRequiredInRole.java f8ab954
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServerNameMustMatch.java ab26266
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServersAllIsInvalid.java 7b56324
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/SimpleDBPolicyEngine.java 7224f60
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBAuthorizables.java 347a2c2
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBWildcardPermission.java 71474b3
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestPolicyParsingNegative.java edb715e
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderGeneralCases.java 32ade2b
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderSpecialCases.java 161067b
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestSimpleDBPolicyEngineDFS.java faf4131
> sentry-tests/sentry-tests-hive/pom.xml a9d913f
>
> Diff: https://reviews.apache.org/r/14456/diff/
>
>
> Testing
> -------
>
> Ran the entire test suite.
>
>
> Thanks,
>
> Gregory Chanan
>
>
Re: Review Request 14456: SENTRY-26: Separate sentry-core to hive specific
and non-specific packages
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14456/#review26652
-----------------------------------------------------------
This looks pretty good to me. Nice work! Just one question about the pom below and some trailing ws.
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/AccessURI.java
<https://reviews.apache.org/r/14456/#comment51927>
trailing ws
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/DBAuthorizable.java
<https://reviews.apache.org/r/14456/#comment51928>
trailing ws
sentry-tests/sentry-tests-hive/pom.xml
<https://reviews.apache.org/r/14456/#comment51929>
I am not as familiar with these poms as of late. Why are deleting this entry?
- Brock Noland
On Oct. 3, 2013, 1:24 a.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14456/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2013, 1:24 a.m.)
>
>
> Review request for sentry, Brock Noland and Shreepadma Venugopalan.
>
>
> Bugs: SENTRY-26
> https://issues.apache.org/jira/browse/SENTRY-26
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Separated core into core-common and core-db, similar to SENTRY-17.
>
> Highlights:
> - Authorizable and Action become interfaces actually implemented via DBAuthorizable and DBAction
> - There was only one instance of "getAuthzType()" being called from a common (non-db-specific) implementation, in ResourceAuthorizationProvider. The usage is "getAuthzType().getName()". To support this I added another function to Authorizable, "getTypeName"
>
> I think the rest is fairly straightforward
>
>
> Diffs
> -----
>
> pom.xml 439ce32
> sentry-binding/sentry-binding-hive/pom.xml 5c3e17a
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 28b192f
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingPreExecHook.java 28812c5
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContext.java a57c510
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContextImpl.java e2142df
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java 8ecb41b
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivileges.java 2c480ef
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java b7340a2
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java d3d44d2
> sentry-core/pom.xml 6afdd4a
> sentry-core/sentry-core-common/pom.xml PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Authorizable.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizationProvider.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/NoAuthorizationProvider.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Subject.java PRE-CREATION
> sentry-core/sentry-core-db/pom.xml PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/AccessConstants.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/AccessURI.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/DBAction.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/DBAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Database.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Server.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/ServerResource.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Table.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/TableOrView.java PRE-CREATION
> sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/View.java PRE-CREATION
> sentry-core/sentry-core-db/src/test/java/org/apache/sentry/core/db/TestURI.java PRE-CREATION
> sentry-core/src/main/java/org/apache/sentry/core/AccessConstants.java 7551a1d
> sentry-core/src/main/java/org/apache/sentry/core/AccessURI.java e6d817e
> sentry-core/src/main/java/org/apache/sentry/core/Action.java 94e1984
> sentry-core/src/main/java/org/apache/sentry/core/Authorizable.java 2849a9f
> sentry-core/src/main/java/org/apache/sentry/core/AuthorizationProvider.java c026fce
> sentry-core/src/main/java/org/apache/sentry/core/Database.java 169057d
> sentry-core/src/main/java/org/apache/sentry/core/NoAuthorizationProvider.java a0a6201
> sentry-core/src/main/java/org/apache/sentry/core/Server.java caed9a9
> sentry-core/src/main/java/org/apache/sentry/core/ServerResource.java 91334dc
> sentry-core/src/main/java/org/apache/sentry/core/Subject.java fa5cd6e
> sentry-core/src/main/java/org/apache/sentry/core/Table.java 9053d9a
> sentry-core/src/main/java/org/apache/sentry/core/TableOrView.java d6f8837
> sentry-core/src/main/java/org/apache/sentry/core/View.java 471a09c
> sentry-core/src/test/java/org/apache/sentry/core/TestURI.java 5507285
> sentry-dist/pom.xml 8fc489b
> sentry-dist/src/main/assembly/src.xml af6dfa8
> sentry-provider/sentry-provider-file/pom.xml 85bb23b
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyEngine.java 954e1d5
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/ResourceAuthorizationProvider.java f22fccd
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimplePolicyParser.java f6b87e0
> sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/AbstractTestSimplePolicyEngine.java 5388b0f
> sentry-provider/sentry-provider-policy-db/pom.xml ca6f6f9
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/AbstractDBRoleValidator.java d386d59
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBAuthorizables.java 089e6de
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBRoles.java 499d988
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBWildcardPermission.java 17f5a76
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseMustMatch.java db9d60c
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseRequiredInRole.java f8ab954
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServerNameMustMatch.java ab26266
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServersAllIsInvalid.java 7b56324
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/SimpleDBPolicyEngine.java 7224f60
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBAuthorizables.java 347a2c2
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBWildcardPermission.java 71474b3
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestPolicyParsingNegative.java edb715e
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderGeneralCases.java 32ade2b
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderSpecialCases.java 161067b
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestSimpleDBPolicyEngineDFS.java faf4131
> sentry-tests/sentry-tests-hive/pom.xml a9d913f
>
> Diff: https://reviews.apache.org/r/14456/diff/
>
>
> Testing
> -------
>
> Ran the entire test suite.
>
>
> Thanks,
>
> Gregory Chanan
>
>
Re: Review Request 14456: SENTRY-26: Separate sentry-core to hive specific
and non-specific packages
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14456/#review26675
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On Oct. 3, 2013, 10:18 p.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14456/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2013, 10:18 p.m.)
>
>
> Review request for sentry, Brock Noland and Shreepadma Venugopalan.
>
>
> Bugs: SENTRY-26
> https://issues.apache.org/jira/browse/SENTRY-26
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Separated core into core-common and core-db, similar to SENTRY-17.
>
> Highlights:
> - Authorizable and Action become interfaces actually implemented via DBAuthorizable and DBAction
> - There was only one instance of "getAuthzType()" being called from a common (non-db-specific) implementation, in ResourceAuthorizationProvider. The usage is "getAuthzType().getName()". To support this I added another function to Authorizable, "getTypeName"
>
> I think the rest is fairly straightforward
>
>
> Diffs
> -----
>
> pom.xml 439ce32
> sentry-binding/sentry-binding-hive/pom.xml 5c3e17a
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 28b192f
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingPreExecHook.java 28812c5
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContext.java a57c510
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContextImpl.java e2142df
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java 8ecb41b
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivileges.java 2c480ef
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java b7340a2
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java d3d44d2
> sentry-core/pom.xml 6afdd4a
> sentry-core/sentry-core-common/pom.xml PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Authorizable.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizationProvider.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/NoAuthorizationProvider.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Subject.java PRE-CREATION
> sentry-core/src/main/java/org/apache/sentry/core/AccessConstants.java 7551a1d
> sentry-core/src/main/java/org/apache/sentry/core/AccessURI.java e6d817e
> sentry-core/src/main/java/org/apache/sentry/core/Action.java 94e1984
> sentry-core/src/main/java/org/apache/sentry/core/Authorizable.java 2849a9f
> sentry-core/src/main/java/org/apache/sentry/core/AuthorizationProvider.java c026fce
> sentry-core/src/main/java/org/apache/sentry/core/Database.java 169057d
> sentry-core/src/main/java/org/apache/sentry/core/NoAuthorizationProvider.java a0a6201
> sentry-core/src/main/java/org/apache/sentry/core/Server.java caed9a9
> sentry-core/src/main/java/org/apache/sentry/core/ServerResource.java 91334dc
> sentry-core/src/main/java/org/apache/sentry/core/Subject.java fa5cd6e
> sentry-core/src/main/java/org/apache/sentry/core/Table.java 9053d9a
> sentry-core/src/main/java/org/apache/sentry/core/TableOrView.java d6f8837
> sentry-core/src/main/java/org/apache/sentry/core/View.java 471a09c
> sentry-core/src/test/java/org/apache/sentry/core/TestURI.java 5507285
> sentry-dist/pom.xml 8fc489b
> sentry-dist/src/main/assembly/src.xml af6dfa8
> sentry-provider/sentry-provider-file/pom.xml 85bb23b
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyEngine.java 954e1d5
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/ResourceAuthorizationProvider.java f22fccd
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimplePolicyParser.java f6b87e0
> sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/AbstractTestSimplePolicyEngine.java 5388b0f
> sentry-provider/sentry-provider-policy-db/pom.xml ca6f6f9
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/AbstractDBRoleValidator.java d386d59
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBAuthorizables.java 089e6de
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBModelAuthorizables.java PRE-CREATION
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBRoles.java 499d988
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBWildcardPermission.java 17f5a76
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseMustMatch.java db9d60c
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseRequiredInRole.java f8ab954
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServerNameMustMatch.java ab26266
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServersAllIsInvalid.java 7b56324
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/SimpleDBPolicyEngine.java 7224f60
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBAuthorizables.java 347a2c2
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBModelAuthorizables.java PRE-CREATION
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBWildcardPermission.java 71474b3
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestPolicyParsingNegative.java edb715e
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderGeneralCases.java 32ade2b
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderSpecialCases.java 161067b
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestSimpleDBPolicyEngineDFS.java faf4131
> sentry-tests/sentry-tests-hive/pom.xml a9d913f
>
> Diff: https://reviews.apache.org/r/14456/diff/
>
>
> Testing
> -------
>
> Ran the entire test suite.
>
>
> Thanks,
>
> Gregory Chanan
>
>
Re: Review Request 14456: SENTRY-26: Separate sentry-core to hive specific
and non-specific packages
Posted by Gregory Chanan <gc...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14456/
-----------------------------------------------------------
(Updated Oct. 3, 2013, 10:18 p.m.)
Review request for sentry, Brock Noland and Shreepadma Venugopalan.
Changes
-------
To make it more obvious we are talking about the DB Model rather than the DB backend, or Database object, I've done the following:
1) Rename DBAuthorizable to DBModelAuthorizable
2) Rename DBAction to DBModelAction
3) Rename module core-db to core-model-db
Bugs: SENTRY-26
https://issues.apache.org/jira/browse/SENTRY-26
Repository: sentry
Description
-------
Separated core into core-common and core-db, similar to SENTRY-17.
Highlights:
- Authorizable and Action become interfaces actually implemented via DBAuthorizable and DBAction
- There was only one instance of "getAuthzType()" being called from a common (non-db-specific) implementation, in ResourceAuthorizationProvider. The usage is "getAuthzType().getName()". To support this I added another function to Authorizable, "getTypeName"
I think the rest is fairly straightforward
Diffs (updated)
-----
pom.xml 439ce32
sentry-binding/sentry-binding-hive/pom.xml 5c3e17a
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 28b192f
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingPreExecHook.java 28812c5
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContext.java a57c510
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContextImpl.java e2142df
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java 8ecb41b
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivileges.java 2c480ef
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java b7340a2
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java d3d44d2
sentry-core/pom.xml 6afdd4a
sentry-core/sentry-core-common/pom.xml PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Authorizable.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizationProvider.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/NoAuthorizationProvider.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Subject.java PRE-CREATION
sentry-core/src/main/java/org/apache/sentry/core/AccessConstants.java 7551a1d
sentry-core/src/main/java/org/apache/sentry/core/AccessURI.java e6d817e
sentry-core/src/main/java/org/apache/sentry/core/Action.java 94e1984
sentry-core/src/main/java/org/apache/sentry/core/Authorizable.java 2849a9f
sentry-core/src/main/java/org/apache/sentry/core/AuthorizationProvider.java c026fce
sentry-core/src/main/java/org/apache/sentry/core/Database.java 169057d
sentry-core/src/main/java/org/apache/sentry/core/NoAuthorizationProvider.java a0a6201
sentry-core/src/main/java/org/apache/sentry/core/Server.java caed9a9
sentry-core/src/main/java/org/apache/sentry/core/ServerResource.java 91334dc
sentry-core/src/main/java/org/apache/sentry/core/Subject.java fa5cd6e
sentry-core/src/main/java/org/apache/sentry/core/Table.java 9053d9a
sentry-core/src/main/java/org/apache/sentry/core/TableOrView.java d6f8837
sentry-core/src/main/java/org/apache/sentry/core/View.java 471a09c
sentry-core/src/test/java/org/apache/sentry/core/TestURI.java 5507285
sentry-dist/pom.xml 8fc489b
sentry-dist/src/main/assembly/src.xml af6dfa8
sentry-provider/sentry-provider-file/pom.xml 85bb23b
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyEngine.java 954e1d5
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/ResourceAuthorizationProvider.java f22fccd
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimplePolicyParser.java f6b87e0
sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/AbstractTestSimplePolicyEngine.java 5388b0f
sentry-provider/sentry-provider-policy-db/pom.xml ca6f6f9
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/AbstractDBRoleValidator.java d386d59
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBAuthorizables.java 089e6de
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBModelAuthorizables.java PRE-CREATION
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBRoles.java 499d988
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBWildcardPermission.java 17f5a76
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseMustMatch.java db9d60c
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseRequiredInRole.java f8ab954
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServerNameMustMatch.java ab26266
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServersAllIsInvalid.java 7b56324
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/SimpleDBPolicyEngine.java 7224f60
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBAuthorizables.java 347a2c2
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBModelAuthorizables.java PRE-CREATION
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBWildcardPermission.java 71474b3
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestPolicyParsingNegative.java edb715e
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderGeneralCases.java 32ade2b
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderSpecialCases.java 161067b
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestSimpleDBPolicyEngineDFS.java faf4131
sentry-tests/sentry-tests-hive/pom.xml a9d913f
Diff: https://reviews.apache.org/r/14456/diff/
Testing
-------
Ran the entire test suite.
Thanks,
Gregory Chanan
Re: Review Request 14456: SENTRY-26: Separate sentry-core to hive specific
and non-specific packages
Posted by Gregory Chanan <gc...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14456/
-----------------------------------------------------------
(Updated Oct. 3, 2013, 6:29 p.m.)
Review request for sentry, Brock Noland and Shreepadma Venugopalan.
Changes
-------
Updated for Brock's comments.
Bugs: SENTRY-26
https://issues.apache.org/jira/browse/SENTRY-26
Repository: sentry
Description
-------
Separated core into core-common and core-db, similar to SENTRY-17.
Highlights:
- Authorizable and Action become interfaces actually implemented via DBAuthorizable and DBAction
- There was only one instance of "getAuthzType()" being called from a common (non-db-specific) implementation, in ResourceAuthorizationProvider. The usage is "getAuthzType().getName()". To support this I added another function to Authorizable, "getTypeName"
I think the rest is fairly straightforward
Diffs (updated)
-----
pom.xml 439ce32
sentry-binding/sentry-binding-hive/pom.xml 5c3e17a
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 28b192f
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingPreExecHook.java 28812c5
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContext.java a57c510
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryOnFailureHookContextImpl.java e2142df
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java 8ecb41b
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivileges.java 2c480ef
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java b7340a2
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java d3d44d2
sentry-core/pom.xml 6afdd4a
sentry-core/sentry-core-common/pom.xml PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Authorizable.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizationProvider.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/NoAuthorizationProvider.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Subject.java PRE-CREATION
sentry-core/sentry-core-db/pom.xml PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/AccessConstants.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/AccessURI.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/DBAction.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/DBAuthorizable.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Database.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Server.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/ServerResource.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/Table.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/TableOrView.java PRE-CREATION
sentry-core/sentry-core-db/src/main/java/org/apache/sentry/core/db/View.java PRE-CREATION
sentry-core/sentry-core-db/src/test/java/org/apache/sentry/core/db/TestURI.java PRE-CREATION
sentry-core/src/main/java/org/apache/sentry/core/AccessConstants.java 7551a1d
sentry-core/src/main/java/org/apache/sentry/core/AccessURI.java e6d817e
sentry-core/src/main/java/org/apache/sentry/core/Action.java 94e1984
sentry-core/src/main/java/org/apache/sentry/core/Authorizable.java 2849a9f
sentry-core/src/main/java/org/apache/sentry/core/AuthorizationProvider.java c026fce
sentry-core/src/main/java/org/apache/sentry/core/Database.java 169057d
sentry-core/src/main/java/org/apache/sentry/core/NoAuthorizationProvider.java a0a6201
sentry-core/src/main/java/org/apache/sentry/core/Server.java caed9a9
sentry-core/src/main/java/org/apache/sentry/core/ServerResource.java 91334dc
sentry-core/src/main/java/org/apache/sentry/core/Subject.java fa5cd6e
sentry-core/src/main/java/org/apache/sentry/core/Table.java 9053d9a
sentry-core/src/main/java/org/apache/sentry/core/TableOrView.java d6f8837
sentry-core/src/main/java/org/apache/sentry/core/View.java 471a09c
sentry-core/src/test/java/org/apache/sentry/core/TestURI.java 5507285
sentry-dist/pom.xml 8fc489b
sentry-dist/src/main/assembly/src.xml af6dfa8
sentry-provider/sentry-provider-file/pom.xml 85bb23b
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyEngine.java 954e1d5
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/ResourceAuthorizationProvider.java f22fccd
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimplePolicyParser.java f6b87e0
sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/AbstractTestSimplePolicyEngine.java 5388b0f
sentry-provider/sentry-provider-policy-db/pom.xml ca6f6f9
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/AbstractDBRoleValidator.java d386d59
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBAuthorizables.java 089e6de
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBRoles.java 499d988
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBWildcardPermission.java 17f5a76
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseMustMatch.java db9d60c
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseRequiredInRole.java f8ab954
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServerNameMustMatch.java ab26266
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServersAllIsInvalid.java 7b56324
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/SimpleDBPolicyEngine.java 7224f60
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBAuthorizables.java 347a2c2
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBWildcardPermission.java 71474b3
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestPolicyParsingNegative.java edb715e
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderGeneralCases.java 32ade2b
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderSpecialCases.java 161067b
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestSimpleDBPolicyEngineDFS.java faf4131
sentry-tests/sentry-tests-hive/pom.xml a9d913f
Diff: https://reviews.apache.org/r/14456/diff/
Testing
-------
Ran the entire test suite.
Thanks,
Gregory Chanan