You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2026/04/02 08:13:55 UTC
[PR] chore(deps): bump react-router-dom from 5.3.4 to 7.13.2 in /superset-frontend [superset]
dependabot[bot] opened a new pull request, #39058:
URL: https://github.com/apache/superset/pull/39058
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 5.3.4 to 7.13.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/remix-run/react-router/releases">react-router-dom's releases</a>.</em></p>
<blockquote>
<h2>v7.1.3</h2>
<p>See the changelog for release notes: <a href="https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v713">https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v713</a></p>
<h2>v6.4.4</h2>
<h2>What's Changed</h2>
<ul>
<li>Throw an error if an <code>action</code>/<code>loader</code> function returns <code>undefined</code> as revalidations need to know whether the loader has previously been executed. <code>undefined</code> also causes issues during SSR stringification for hydration. You should always ensure your <code>loader</code>/<code>action</code> returns a value, and you may return <code>null</code> if you don't wish to return anything. (<a href="https://redirect.github.com/remix-run/react-router/pull/9511">#9511</a>)</li>
<li>Properly handle redirects to external domains (<a href="https://redirect.github.com/remix-run/react-router/pull/9590">#9590</a>, <a href="https://redirect.github.com/remix-run/react-router/pull/9654">#9654</a>)</li>
<li>Preserve the HTTP method on 307/308 redirects (<a href="https://redirect.github.com/remix-run/react-router/pull/9597">#9597</a>)</li>
<li>Support <code>basename</code> in static data routers (<a href="https://redirect.github.com/remix-run/react-router/pull/9591">#9591</a>)</li>
<li>Enhanced <code>ErrorResponse</code> bodies to contain more descriptive text in internal 403/404/405 scenarios</li>
<li>Fix issues with encoded characters in <code>NavLink</code> and descendant <code><Routes></code> (<a href="https://redirect.github.com/remix-run/react-router/pull/9589">#9589</a>, <a href="https://redirect.github.com/remix-run/react-router/pull/9647">#9647</a>)</li>
<li>Properly serialize/deserialize <code>ErrorResponse</code> instances when using built-in hydration (<a href="https://redirect.github.com/remix-run/react-router/pull/9593">#9593</a>)</li>
<li>Support <code>basename</code> in static data routers (<a href="https://redirect.github.com/remix-run/react-router/pull/9591">#9591</a>)</li>
<li>Updated dependencies:
<ul>
<li><code>@remix-run/router@1.0.4</code></li>
<li><code>react-router@6.4.4</code></li>
</ul>
</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/remix-run/react-router/compare/react-router-dom@6.4.3...react-router-dom@6.4.4">https://github.com/remix-run/react-router/compare/react-router-dom@6.4.3...react-router-dom@6.4.4</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md">react-router-dom's changelog</a>.</em></p>
<blockquote>
<h2>7.13.2</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.13.2</code></li>
</ul>
</li>
</ul>
<h2>7.13.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.13.1</code></li>
</ul>
</li>
</ul>
<h2>7.13.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.13.0</code></li>
</ul>
</li>
</ul>
<h2>7.12.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.12.0</code></li>
</ul>
</li>
</ul>
<h2>7.11.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.11.0</code></li>
</ul>
</li>
</ul>
<h2>7.10.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.10.1</code></li>
</ul>
</li>
</ul>
<h2>7.10.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.10.0</code></li>
</ul>
</li>
</ul>
<h2>7.9.6</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/remix-run/react-router/commit/aadb56fa532e0eaf7e7b91c1d88e1f325851eb04"><code>aadb56f</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14908">#14908</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/c68a9b35933fe5a3750ea8e52399d06f9aaecf77"><code>c68a9b3</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14893">#14893</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/aa3f07883c04a4c1da7bfc4d6beb1f1f8c2dfa4c"><code>aa3f078</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14829">#14829</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/3207a5cc3278b7212aeb95331107ec052d5a3008"><code>3207a5c</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14814">#14814</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/5557ba3f848e52dfe400a47cc28256a51e13a150"><code>5557ba3</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14749">#14749</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/62c6e0effd9ae754fa05b1812fd013341226c0cb"><code>62c6e0e</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14738">#14738</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/26653a6bcbf8a9c5541f99dcfb526eafadf13434"><code>26653a6</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14712">#14712</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/7ac2346873b4bba26d16c88e5cd5c5cb81ce6bb3"><code>7ac2346</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14709">#14709</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/b34a9cd1f74231ded97c1e6ca9dff8f09a1b87ca"><code>b34a9cd</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14668">#14668</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/48b1be47a4a827cef1d012f2f6e64003c93054b0"><code>48b1be4</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14662">#14662</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/remix-run/react-router/commits/react-router-dom@7.13.2/packages/react-router-dom">compare view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by [GitHub Actions](<a href="https://www.npmjs.com/~GitHub">https://www.npmjs.com/~GitHub</a> Actions), a new releaser for react-router-dom since your current version.</p>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump react-router-dom from 5.3.4 to 7.13.2 in /superset-frontend [superset]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] closed pull request #39058: chore(deps): bump react-router-dom from 5.3.4 to 7.13.2 in /superset-frontend
URL: https://github.com/apache/superset/pull/39058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump react-router-dom from 5.3.4 to 7.13.2 in /superset-frontend [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #39058:
URL: https://github.com/apache/superset/pull/39058#issuecomment-4181909922
## Dependabot Review: CI Failing — MAJOR BREAKING CHANGE (React Router v5 → v7)
**CI Status:** 21 failures (frontend-build, cypress, playwright, lint, translations — all downstream of build failure)
**Root Cause & Breaking Changes:**
This is a **v5 → v7 major version jump** — one of the largest breaking changes in the React ecosystem. React Router v6 and v7 have a **completely rewritten API**:
### Breaking Changes Summary:
- **Switch removed** → replaced by Routes
- **Route syntax changed** → component/render/children props replaced by `element={<Component />}`
- **useHistory() removed** → replaced by `useNavigate()`
- **useRouteMatch() removed** → replaced by `useMatch()`
- **withRouter() HOC removed** → must use hooks
- **Nested routes** → must use Outlet pattern
- **Redirect removed** → replaced by Navigate
- **React Router v7 = Remix** migration path — adds framework-level features
Superset's codebase has **extensive use of React Router v5 APIs** across hundreds of components. This migration requires a full codebase audit and refactor.
**Estimated effort:** Large (days to weeks) — cannot be merged as-is.
**Note:** This PR supersedes #38223 (which targets v7.13.1; this targets v7.13.2).
**Recommendation:** ❌ Do NOT merge. This requires a dedicated migration effort:
1. Replace all Switch with Routes
2. Replace all Redirect with Navigate
3. Replace all useHistory() with useNavigate()
4. Replace all useRouteMatch() with useMatch()
5. Replace all withRouter() HOCs with hook-based patterns
6. Audit all nested route patterns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump react-router-dom from 5.3.4 to 7.13.2 in /superset-frontend [superset]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] commented on PR #39058:
URL: https://github.com/apache/superset/pull/39058#issuecomment-4182252094
Superseded by #39086.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump react-router-dom from 5.3.4 to 7.13.2 in /superset-frontend [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39058:
URL: https://github.com/apache/superset/pull/39058#issuecomment-4175501332
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org