You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Greg Miller (Jira)" <ji...@apache.org> on 2022/02/05 00:16:00 UTC
[jira] [Resolved] (LUCENE-10050) Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)
[ https://issues.apache.org/jira/browse/LUCENE-10050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Miller resolved LUCENE-10050.
----------------------------------
Fix Version/s: 9.1
10.0 (main)
Resolution: Fixed
Merged onto {{main}} and backported a less aggressive version (leaving the method there but marking deprecated) on {{{}branch_9x{}}}. Thanks again [~gworah] ! This is a nice little under-the-hood improvement for some drill-sideways users.
> Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-10050
> URL: https://issues.apache.org/jira/browse/LUCENE-10050
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Greg Miller
> Priority: Minor
> Fix For: 9.1, 10.0 (main)
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> With similar motivation to LUCENE-10002, we should consider doing away with the ability to directly provide a Collector to DrillSideways in favor of always accepting a CollectorManager. Just like with IndexSearcher, it's trappy that you can provide an Executor when setting up DrillSideways and then not leverage it by directly providing a single Collector.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org