[GitHub] [pulsar] codelipenghui commented on a change in pull request #13077: PIP-45: Allow to configure metadata store URL in broker.conf

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #13077:
URL: https://github.com/apache/pulsar/pull/13077#discussion_r760723501



##########
File path: conf/broker.conf
##########
@@ -19,11 +19,15 @@
 
 ### --- General broker settings --- ###
 
-# Zookeeper quorum connection string
-zookeeperServers=
+# The metadata store URL
+# Examples:
+# * zk:my-zk-1:2181,my-zk-2:2181,my-zk-3:2181
+# * my-zk-1:2181,my-zk-2:2181,my-zk-3:2181 (will default to ZooKeeper when the schema is not specified)
+# * zk:my-zk-1:2181,my-zk-2:2181,my-zk-3:2181/my-chroot-path (to add a ZK chroot path)
+metadataStoreUrl=
 
-# Configuration Store connection string
-configurationStoreServers=
+# The metadata store URL for the configuration data. If empty, we fall back to use metadataStoreUrl
+configurationMetadataStoreUrl=

Review comment:
       It's will be a breaking change when we use the docker image? If we don't have this configuration in the broker.conf, we need to add PULSAR_PREFIX I think.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org