You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/18 07:21:51 UTC

[GitHub] [shardingsphere] dongzl commented on a change in pull request #6906: fixes SQLServer SQL “columnNames” parser, instead of “columnNameWithSort".

dongzl commented on a change in pull request #6906:
URL: https://github.com/apache/shardingsphere/pull/6906#discussion_r471967112



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/BaseRule.g4
##########
@@ -119,7 +119,7 @@ name
     ;
 
 columnNames
-    : LP_ columnNameWithSort (COMMA_ columnNameWithSort)* RP_
+    : LP_ columnName (COMMA_ columnName)* RP_

Review comment:
       Hi @jingshanglu , `columnNames` also use in the `insertValuesClause`, if use `columnNameWithSort`, I test the `insert into t_order (order_id asc, user_id desc) values (1, 1)` is also a correct sql.
   
   Do we need divide the different rule for `createIndex `  and `insert`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org