[GitHub] [hive] aasha commented on a change in pull request #2083: HIVE-24895. Add a DataCopyEnd stage in ReplStateLogTask for external table replication.

[GitBox <gi...@apache.org>]

aasha commented on a change in pull request #2083:
URL: https://github.com/apache/hive/pull/2083#discussion_r603191387



##########
File path: ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/StageType.java
##########
@@ -31,7 +31,8 @@
   RANGER_DUMP(19),
   RANGER_LOAD(20),
   ATLAS_DUMP(21),
-  ATLAS_LOAD(22);
+  ATLAS_LOAD(22),
+  COPY_LOG(23);
 
   private final int value;

Review comment:
       this is a thrift gen file. Should modify the thrift file and regenrate these gen files

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/DirCopyTask.java
##########
@@ -182,6 +183,13 @@ public int execute() {
       Exception ex = new SecurityException(ErrorMsg.REPL_RETRY_EXHAUSTED.format(e.getMessage()), e);
       setException(ex);
       return ReplUtils.handleException(true, ex, work.getDumpDirectory(), work.getMetricCollector(), getName(), conf);
+    } finally {
+      String jobId = conf.get("distcp.job.id", "UNAVAILABLE");

Review comment:
       print no of retries as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org