[GitHub] [flink] XComp edited a comment on pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters

[GitBox <gi...@apache.org>]

XComp edited a comment on pull request #17819:
URL: https://github.com/apache/flink/pull/17819#issuecomment-1020406101


   Ok, then I misinterpreted the ticket. Essentially, the issue is not that we have to guess the right value for this configuration parameter but that the validation never happens for standalone clusters with HA enabled. But I don't understand you claim that it make sense to have the REST suffix included in `KubernetesLabel`. I cannot even find a place where we use the `clusterId` + `-rest` as a label key or value.
   
   Why do we have such an odd value (i.e. 45) for `MAXIMUM_CHARACTERS_OF_CLUSTER_ID` in the first place. Shouldn't it be 63 then? As a consequence, that would mean that we only have to have a single accessor for `KubernetesConfigOptions.CLUSTER_ID` that checks whether the specified `clusterId` is 63 characters or less, wouldn't it?
   
   Are there references to where the labels (i.e. the resources limited to 63 characters) are set?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org