You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/24 06:22:25 UTC

[GitHub] [shardingsphere] terrymanu commented on pull request #8740: Add condition expression assertion for ExpectedJoinTable.

terrymanu commented on pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#issuecomment-750765126


   > > It is unnecessary to change the package name, can you revert that?
   > 
   > @terrymanu
   > 
   > Rename `impl.expr` to `impl.expression` is in order to be consistent with the name under `asserts.segment` (`org.apache.shardingsphere.test.sql.parser.parameterized.asserts.segment.expression`).
   > 
   > Maybe I should rename `asserts.segment.expression` to `asserts.segment.expr`?
   > Becasue `ExpressionSegment` is under package `org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr`.
   
   If rename is necessary, it is better to split them to another pr.
   It is easy to review if one pr do one thing only.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org