You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ho...@apache.org on 2016/12/09 17:02:35 UTC
lucene-solr:jira/solr-5944: add nocommit comment regarding default=0
so we don't forget to clean that up
Repository: lucene-solr
Updated Branches:
refs/heads/jira/solr-5944 b0059ff31 -> e2ced0b8e
add nocommit comment regarding default=0 so we don't forget to clean that up
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/e2ced0b8
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/e2ced0b8
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/e2ced0b8
Branch: refs/heads/jira/solr-5944
Commit: e2ced0b8e8e470850cf8c6576e284ab17b474a92
Parents: b0059ff
Author: Chris Hostetter <ho...@apache.org>
Authored: Fri Dec 9 10:02:25 2016 -0700
Committer: Chris Hostetter <ho...@apache.org>
Committed: Fri Dec 9 10:02:25 2016 -0700
----------------------------------------------------------------------
.../test-files/solr/collection1/conf/schema-inplace-updates.xml | 4 ++++
1 file changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/e2ced0b8/solr/core/src/test-files/solr/collection1/conf/schema-inplace-updates.xml
----------------------------------------------------------------------
diff --git a/solr/core/src/test-files/solr/collection1/conf/schema-inplace-updates.xml b/solr/core/src/test-files/solr/collection1/conf/schema-inplace-updates.xml
index 77b852d..2676f0a 100644
--- a/solr/core/src/test-files/solr/collection1/conf/schema-inplace-updates.xml
+++ b/solr/core/src/test-files/solr/collection1/conf/schema-inplace-updates.xml
@@ -21,6 +21,10 @@
<field name="_version_" type="long" indexed="false" stored="false" docValues="true" />
<!-- specific schema fields for dv in-place updates -->
+ <!-- nocommit: most tests should be able to pass w/o these fields having default="0" -->
+ <!-- nocommit: if any tests that actaully depend/use the the default field value,
+ nocommit: then they should be changed to use a new field, with a non-0 default,
+ nocommit: so we don't risk confusion with an *implicit* (in code) default of 0 -->
<field name="inplace_updatable_float" type="float" indexed="false" stored="false" docValues="true" default="0"/>
<field name="inplace_updatable_int" type="int" indexed="false" stored="false" docValues="true" default="0"/>