[GitHub] lucene-solr issue #421: SOLR-7557: Fix parsing of child documents using quer...

[janhoy <gi...@git.apache.org>]

Github user janhoy commented on the issue:

    https://github.com/apache/lucene-solr/pull/421
  
    Great. What's the reason for adding another child document to the test? 
    
    Please do the following changes
    * Move the test to `SolrExampleStreamingBinaryTest` (don't need to test it for all clients
    * Rename the test `testQueryAndStreamResponse` as it is the response parsing we're testing
    * Add this line in `solr/CHANGES.txt` under 7.6.0 version and section "Bug Fixes" (appx line 215)
    
          * SOLR-7557: Fix parsing of child documents using queryAndStreamResponse (Marvin Bredal Lillehaug via janhoy) 
    * Make sure the PR is up-to-date with current master
    
    Then I'll be able to merge it directly and you also get credit in git log :) 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org