You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/01/06 09:45:50 UTC
[GitHub] liketic opened a new pull request #3310: Add a running flag for
Kafka source connector
liketic opened a new pull request #3310: Add a running flag for Kafka source connector
URL: https://github.com/apache/pulsar/pull/3310
### Motivation
Currently, if we pass an invalid source configuration to instantiate ```KafkaConsumer``` we will get no log even there is an exception thrown. And after ```close()``` called, the background thread may still alive unless we caught an ```InterruptedException``` if ```kafkaSourceConfig.isAutoCommitEnabled()``` returns ```false```. So I would like to add a flag to indicate if the connector is stopped.
### Modifications
Describe the modifications you've done.
### Result
After your change, what will change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services