[GitHub] [hudi] wangxianghu commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties

[GitBox <gi...@apache.org>]

wangxianghu commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067854086


   hi @codope This patch solved  issue https://github.com/apache/hudi/issues/5026
   but if the user use
   ```
   typedProperties.put("key", 123);
   ```
   the kv still lost
   
   may be we should override java.util.Properties#getProperty(java.lang.String) to ingnore the val type
   ```
       public String getProperty(String key) {
           Object oval = super.get(key);
           String sval = (oval instanceof String) ? (String)oval : null;
           return ((sval == null) && (defaults != null)) ? defaults.getProperty(key) : sval;
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org