You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/26 02:29:49 UTC

[GitHub] leezu commented on a change in pull request #13209: Allow dataloader iterator to be reused

leezu commented on a change in pull request #13209: Allow dataloader iterator to be reused
URL: https://github.com/apache/incubator-mxnet/pull/13209#discussion_r236107523
 
 

 ##########
 File path: python/mxnet/gluon/data/dataloader.py
 ##########
 @@ -363,13 +449,8 @@ def __init__(self, dataset, batch_size=None, shuffle=False, sampler=None,
 
     def __iter__(self):
 
 Review comment:
   Would it make sense to add documentation about the API of returned `_SameProcessIter` / `_MultiWorkerIter`? Ie. that they will reset when `__iter__` is called on them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services