You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by Christofer Dutz <ch...@c-ware.de> on 2017/10/02 12:52:54 UTC

Re: maven: war LICENSE file

Hi all,

I just committed some more changes to the java8 and jaca7 console. I hope that now all should be in place and the modules should be ok from a legal point of view. 
Unfortunately, I had to jump though quite a lot of hoops in order to get everything working correctly. But now I think all is good and I did learn quite a bit from that.

A big thanks to Justin who helped me a lot by inspecting tons of war and jar files I sent him via my Google Drive. It would have taken quite a lot of iterations without that help :-)

Please inspect my latest changes and especially their output.

Chris




Am 29.09.17, 11:55 schrieb "Christofer Dutz" <ch...@c-ware.de>:

    Hi Justin,
    
    so, I invested some time today to address the licensing requirements. I currently just did that for the servlets module. If that’s ok, then I’ll apply similar changes to the server jar.
    Now the build generates a THIRD-PARTY.txt file containing the license names and the module names which are included in the archive
    Additionally the “license” directory contains the textual versoins (TXT or HTML) of the licenses.
    
    Chris
    
    
    Am 27.09.17, 06:45 schrieb "Justin Mclean" <ju...@classsoftware.com>:
    
        Hi,
        
        > Chris, while the enhancement to make the war’s WEB-INF/classes/META-INF/DEPENDENCIES complete with info for bundled external jars is great, I believe the war’s LICENSE still needs to have that info too… or more sensibly the LICENSE needs to include a reference to that info.  Don’t shoot the messenger! :-)
        
        I've taken a quick look and the war/jar bundles:
        
        BSD licensed D3 3.3.9 [1]
        BSD ;licensed d3-plugins-sankey 
        MIT licensed  d3.legend.js
        MIT licensed jQuery 1.11.2
        MIT licensed jQueryUI 1.11.4
        Apache licensed gson-2.8.0
        Apache licensed metrics-core-3.1.2
        
        All of the MIT and BSD licenses need to be added to license, the Apache licensed one can be but are optional.
        
        Metrics includes a NOTICE file [1] and that will effect our NOTICE file. i.e. it’s contents will need to be added.
        
        Thanks,
        Justin
        
        1. https://github.com/dropwizard/metrics/blob/4.0-development/NOTICE

Re: maven: war LICENSE file

Posted by Dale LaBossiere <dm...@gmail.com>.
Sounds good.  The dynamic download was cool but having more places with duplicated/manually sync’d info was a bit ugly :-)
I’ll pull and check it out!

— Dale

> On Oct 3, 2017, at 7:44 AM, Christofer Dutz <ch...@c-ware.de> wrote:
> 
> Hi Dale,
> 
> So, I completely removed the usage of the license-maven-plugin and hereby also removed all of these licenses.xml files. 
> Thinking about what I was planning on using it for, seemed a little over the top for just downloading 5 text files. So, I decided to check-in these license texts and to have default maven mechanisms copy them into the project.
> I think things are a lot less complicated this way.
> 
> Chris
> 
> 
> 
> Am 02.10.17, 23:09 schrieb "Dale LaBossiere" <dm...@gmail.com>:
> 
>    Hi Chris, I see you added a bunch of comments to the wiki, thanks!
> 
>    I think we has a misunderstanding :-)  There are many artifacts that *have* an entry in license.xml but are not bundled.  e.g., junit, jetty-*.
>    That’s what I was trying to say in the tables.  Shouldn’t only bundled things be present in license.xml?
> 
>    — Dale
> 
> 
>> On Oct 2, 2017, at 1:34 PM, Dale LaBossiere <dm...@gmail.com> wrote:
>> 
>> I did a review and captured what I learned along with questions and/or problems in new item 21 (at the bottom of) [1]
>> The details (table) are for only console/servlets at the moment.  I’ll be doing similar for console/server shortly.
>> 
>> [1] https://cwiki.apache.org/confluence/display/EDGENT/Maven+vs+Gradle <https://cwiki.apache.org/confluence/display/EDGENT/Maven+vs+Gradle>
>> 
>> Thanks!
>> — Dale
>> 
>>> On Oct 2, 2017, at 9:07 AM, Dale LaBossiere <dml.apache@gmail.com <ma...@gmail.com>> wrote:
>>> 
>>> I’m on it!
>>> 
>>>> On Oct 2, 2017, at 8:52 AM, Christofer Dutz <christofer.dutz@c-ware.de <ma...@c-ware.de>> wrote:
>>>> ...
>>>> I just committed some more changes to the java8 and jaca7 console. I hope that now all should be in place and the modules should be ok from a legal point of view. 
>>>> ...
>>>> Please inspect my latest changes and especially their output.
>>> 
>> 
> 
> 
>

Re: maven: war LICENSE file

Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Dale,

So, I completely removed the usage of the license-maven-plugin and hereby also removed all of these licenses.xml files. 
Thinking about what I was planning on using it for, seemed a little over the top for just downloading 5 text files. So, I decided to check-in these license texts and to have default maven mechanisms copy them into the project.
I think things are a lot less complicated this way.

Chris



Am 02.10.17, 23:09 schrieb "Dale LaBossiere" <dm...@gmail.com>:

    Hi Chris, I see you added a bunch of comments to the wiki, thanks!
    
    I think we has a misunderstanding :-)  There are many artifacts that *have* an entry in license.xml but are not bundled.  e.g., junit, jetty-*.
    That’s what I was trying to say in the tables.  Shouldn’t only bundled things be present in license.xml?
    
    — Dale
    
    
    > On Oct 2, 2017, at 1:34 PM, Dale LaBossiere <dm...@gmail.com> wrote:
    > 
    > I did a review and captured what I learned along with questions and/or problems in new item 21 (at the bottom of) [1]
    > The details (table) are for only console/servlets at the moment.  I’ll be doing similar for console/server shortly.
    > 
    > [1] https://cwiki.apache.org/confluence/display/EDGENT/Maven+vs+Gradle <https://cwiki.apache.org/confluence/display/EDGENT/Maven+vs+Gradle>
    > 
    > Thanks!
    > — Dale
    > 
    >> On Oct 2, 2017, at 9:07 AM, Dale LaBossiere <dml.apache@gmail.com <ma...@gmail.com>> wrote:
    >> 
    >> I’m on it!
    >> 
    >>> On Oct 2, 2017, at 8:52 AM, Christofer Dutz <christofer.dutz@c-ware.de <ma...@c-ware.de>> wrote:
    >>> ...
    >>> I just committed some more changes to the java8 and jaca7 console. I hope that now all should be in place and the modules should be ok from a legal point of view. 
    >>> ...
    >>> Please inspect my latest changes and especially their output.
    >> 
    >

Re: maven: war LICENSE file

Posted by Christofer Dutz <ch...@c-ware.de>.
Aaaahh … I remember … I think I had that file generated, copied it and fine-tuned the ones that needed tuning. I could remove most of them, I guess … after all it only is used for downloading the license texts for bundled artifacts.

Chris

Am 02.10.17, 23:09 schrieb "Dale LaBossiere" <dm...@gmail.com>:

    Hi Chris, I see you added a bunch of comments to the wiki, thanks!
    
    I think we has a misunderstanding :-)  There are many artifacts that *have* an entry in license.xml but are not bundled.  e.g., junit, jetty-*.
    That’s what I was trying to say in the tables.  Shouldn’t only bundled things be present in license.xml?
    
    — Dale
    
    
    > On Oct 2, 2017, at 1:34 PM, Dale LaBossiere <dm...@gmail.com> wrote:
    > 
    > I did a review and captured what I learned along with questions and/or problems in new item 21 (at the bottom of) [1]
    > The details (table) are for only console/servlets at the moment.  I’ll be doing similar for console/server shortly.
    > 
    > [1] https://cwiki.apache.org/confluence/display/EDGENT/Maven+vs+Gradle <https://cwiki.apache.org/confluence/display/EDGENT/Maven+vs+Gradle>
    > 
    > Thanks!
    > — Dale
    > 
    >> On Oct 2, 2017, at 9:07 AM, Dale LaBossiere <dml.apache@gmail.com <ma...@gmail.com>> wrote:
    >> 
    >> I’m on it!
    >> 
    >>> On Oct 2, 2017, at 8:52 AM, Christofer Dutz <christofer.dutz@c-ware.de <ma...@c-ware.de>> wrote:
    >>> ...
    >>> I just committed some more changes to the java8 and jaca7 console. I hope that now all should be in place and the modules should be ok from a legal point of view. 
    >>> ...
    >>> Please inspect my latest changes and especially their output.
    >> 
    >

Re: maven: war LICENSE file

Posted by Dale LaBossiere <dm...@gmail.com>.
Hi Chris, I see you added a bunch of comments to the wiki, thanks!

I think we has a misunderstanding :-)  There are many artifacts that *have* an entry in license.xml but are not bundled.  e.g., junit, jetty-*.
That’s what I was trying to say in the tables.  Shouldn’t only bundled things be present in license.xml?

— Dale


> On Oct 2, 2017, at 1:34 PM, Dale LaBossiere <dm...@gmail.com> wrote:
> 
> I did a review and captured what I learned along with questions and/or problems in new item 21 (at the bottom of) [1]
> The details (table) are for only console/servlets at the moment.  I’ll be doing similar for console/server shortly.
> 
> [1] https://cwiki.apache.org/confluence/display/EDGENT/Maven+vs+Gradle <https://cwiki.apache.org/confluence/display/EDGENT/Maven+vs+Gradle>
> 
> Thanks!
> — Dale
> 
>> On Oct 2, 2017, at 9:07 AM, Dale LaBossiere <dml.apache@gmail.com <ma...@gmail.com>> wrote:
>> 
>> I’m on it!
>> 
>>> On Oct 2, 2017, at 8:52 AM, Christofer Dutz <christofer.dutz@c-ware.de <ma...@c-ware.de>> wrote:
>>> ...
>>> I just committed some more changes to the java8 and jaca7 console. I hope that now all should be in place and the modules should be ok from a legal point of view. 
>>> ...
>>> Please inspect my latest changes and especially their output.
>> 
>

Re: maven: war LICENSE file

Posted by Dale LaBossiere <dm...@gmail.com>.
I did a review and captured what I learned along with questions and/or problems in new item 21 (at the bottom of) [1]
The details (table) are for only console/servlets at the moment.  I’ll be doing similar for console/server shortly.

[1] https://cwiki.apache.org/confluence/display/EDGENT/Maven+vs+Gradle <https://cwiki.apache.org/confluence/display/EDGENT/Maven+vs+Gradle>

Thanks!
— Dale

> On Oct 2, 2017, at 9:07 AM, Dale LaBossiere <dm...@gmail.com> wrote:
> 
> I’m on it!
> 
>> On Oct 2, 2017, at 8:52 AM, Christofer Dutz <ch...@c-ware.de> wrote:
>> ...
>> I just committed some more changes to the java8 and jaca7 console. I hope that now all should be in place and the modules should be ok from a legal point of view. 
>> ...
>> Please inspect my latest changes and especially their output.
>

Re: maven: war LICENSE file

Posted by Dale LaBossiere <dm...@gmail.com>.
I’m on it!

> On Oct 2, 2017, at 8:52 AM, Christofer Dutz <ch...@c-ware.de> wrote:
> ...
> I just committed some more changes to the java8 and jaca7 console. I hope that now all should be in place and the modules should be ok from a legal point of view. 
> ...
> Please inspect my latest changes and especially their output.