[GitHub] [hadoop-submarine] tangzhankun commented on a change in pull request #8: [SUBMARINE-181] Submarine team manager TeamRestApi

[GitBox <gi...@apache.org>]

tangzhankun commented on a change in pull request #8: [SUBMARINE-181] Submarine team manager TeamRestApi
URL: https://github.com/apache/hadoop-submarine/pull/8#discussion_r327419667
 
 

 ##########
 File path: submarine-workbench/submarine-server/src/main/java/org/apache/submarine/rest/TeamRestApi.java
 ##########
 @@ -119,31 +111,40 @@ public Response add(Team team) {
   public Response edit(Team team) {
     LOG.info("edit team:{}", team.toString());
 
-    // todo(zhulinhao)
-    // 把 team 保存到 team 表中
+    // todo: need set update_by value
+    try {
+      // update team
+      teamService.updateByPrimaryKeySelective(team);
 
-    List<TeamMemeber> memebers = team.getCollaborators();
-    // 将每个 TeamMemeber 保存到 team_member table 中
-    // 前端有如下情况：
-    // 1. 前端没有对成员进行修改
-    // 2. 前端新增了成员
-    // 3. 前端删除了成员
+      // TODO
+      // 将新增的成员中inviter=0，并且没有发送过加入 team 邀请信息
 
 Review comment:
   Please use English to comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services