You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/12 14:31:17 UTC
[GitHub] [trafficserver] cukiernik opened a new pull request #7817: Simplification dir_init_done
cukiernik opened a new pull request #7817:
URL: https://github.com/apache/trafficserver/pull/7817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cukiernik commented on pull request #7817: Simplification dir_init_done
Posted by GitBox <gi...@apache.org>.
cukiernik commented on pull request #7817:
URL: https://github.com/apache/trafficserver/pull/7817#issuecomment-840506960
It is compared to AIO_NOT_IN_PROGRESS, not to ts::NO_FD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cukiernik commented on pull request #7817: Simplification dir_init_done
Posted by GitBox <gi...@apache.org>.
cukiernik commented on pull request #7817:
URL: https://github.com/apache/trafficserver/pull/7817#issuecomment-840516832
> Looks nice, but as long as this is being cleaned up, the symbolic constant `ts::NO_FD` should be used instead of literal "-1". Could you tweak that for me?
Yes, I could, but legal is -1 https://man7.org/linux/man-pages/man2/open.2.html#RETURN_VALUE
It is never compared to ts::NO_FD, but the copy is compared with AIO_NOT_IN_PROGRESS...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7817: Simplification dir_init_done
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7817:
URL: https://github.com/apache/trafficserver/pull/7817#issuecomment-839952481
Looks nice, but as long as this is being cleaned up, the symbolic constant `ts::NO_FD` should be used instead of literal "-1". Could you tweak that for me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cukiernik removed a comment on pull request #7817: Simplification dir_init_done
Posted by GitBox <gi...@apache.org>.
cukiernik removed a comment on pull request #7817:
URL: https://github.com/apache/trafficserver/pull/7817#issuecomment-840506960
It is compared to AIO_NOT_IN_PROGRESS, not to ts::NO_FD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7817: Simplification dir_init_done
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7817:
URL: https://github.com/apache/trafficserver/pull/7817#issuecomment-839930477
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall merged pull request #7817: Simplification dir_init_done
Posted by GitBox <gi...@apache.org>.
bryancall merged pull request #7817:
URL: https://github.com/apache/trafficserver/pull/7817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cukiernik edited a comment on pull request #7817: Simplification dir_init_done
Posted by GitBox <gi...@apache.org>.
cukiernik edited a comment on pull request #7817:
URL: https://github.com/apache/trafficserver/pull/7817#issuecomment-840516832
Yes, I could, but legal is **-1** https://man7.org/linux/man-pages/man2/open.2.html#RETURN_VALUE
It is never compared to ts::NO_FD, but the copy is compared with AIO_NOT_IN_PROGRESS...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org