You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "JooHyukKim (via GitHub)" <gi...@apache.org> on 2023/08/24 11:05:09 UTC
[GitHub] [pulsar] JooHyukKim opened a new pull request, #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile
JooHyukKim opened a new pull request, #21062:
URL: https://github.com/apache/pulsar/pull/21062
Fixes build CI failure in #20764
### Motivation
As title describes. This PR will fix https://github.com/apache/pulsar/actions/runs/5952090719/job/16147560621?pr=20764
### Modifications
As title describes.
### Verifying this change
- [X] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [X] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile
Posted by "JooHyukKim (via GitHub)" <gi...@apache.org>.
JooHyukKim commented on PR #21062:
URL: https://github.com/apache/pulsar/pull/21062#issuecomment-1692560234
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #21062:
URL: https://github.com/apache/pulsar/pull/21062#issuecomment-1691642541
@JooHyukKim I get the point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile
Posted by "JooHyukKim (via GitHub)" <gi...@apache.org>.
JooHyukKim commented on PR #21062:
URL: https://github.com/apache/pulsar/pull/21062#issuecomment-1698647158
There has been a couple of CVE-related version bumps. This PR should pass now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile
Posted by "JooHyukKim (via GitHub)" <gi...@apache.org>.
JooHyukKim commented on PR #21062:
URL: https://github.com/apache/pulsar/pull/21062#issuecomment-1691788878
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile
Posted by "JooHyukKim (via GitHub)" <gi...@apache.org>.
JooHyukKim commented on PR #21062:
URL: https://github.com/apache/pulsar/pull/21062#issuecomment-1691624272
If by "original PR" you mean #20782, no code in core-modules used `pulsar-cli-utils`. #20764 would be the first to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile
Posted by "JooHyukKim (via GitHub)" <gi...@apache.org>.
JooHyukKim commented on PR #21062:
URL: https://github.com/apache/pulsar/pull/21062#issuecomment-1699278733
> Merging...
>
> Keep going @JooHyukKim!
Thankssss! 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21062:
URL: https://github.com/apache/pulsar/pull/21062#issuecomment-1692575434
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21062?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21062](https://app.codecov.io/gh/apache/pulsar/pull/21062?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (709a159) into [master](https://app.codecov.io/gh/apache/pulsar/commit/30073dbac0e941869b43e090d2682935e8f094e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (30073db) will **increase** coverage by `36.40%`.
> Report is 1 commits behind head on master.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/21062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21062 +/- ##
=============================================
+ Coverage 36.73% 73.14% +36.40%
- Complexity 12197 32330 +20133
=============================================
Files 1696 1885 +189
Lines 130039 139726 +9687
Branches 14187 15363 +1176
=============================================
+ Hits 47775 102197 +54422
+ Misses 75926 29442 -46484
- Partials 6338 8087 +1749
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21062/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21062/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.07% <ø> (-0.07%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21062/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `25.14% <ø> (+0.13%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21062/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.40% <ø> (+40.35%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1448 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21062/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #21062:
URL: https://github.com/apache/pulsar/pull/21062#issuecomment-1699105079
Merging...
Keep going @JooHyukKim!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #21062:
URL: https://github.com/apache/pulsar/pull/21062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org