You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Jamie Orchard-Hays (JIRA)" <ji...@apache.org> on 2007/02/09 21:45:05 UTC
[jira] Created: (SOLR-154) Added package tasks for creating Rails
plugin and namespaced both the rails and gem packaging
Added package tasks for creating Rails plugin and namespaced both the rails and gem packaging
---------------------------------------------------------------------------------------------
Key: SOLR-154
URL: https://issues.apache.org/jira/browse/SOLR-154
Project: Solr
Issue Type: Improvement
Components: clients - ruby - flare
Environment: Ruby and Ruby on Rails
Reporter: Jamie Orchard-Hays
Solrb's (sol.rb's?) rake file has a package:vendor task that is not generating proper rails plugin structure. Rather than just fix this, I've added a PackageTask to package up a proper Rails plugin directory structure and also build distributable packages. Included are the README, LICENSE.txt, and init.rb generated and destroyed on the fly. Also, I've names spaced the Gem PackageTask and the Rails PackageTask, so the commands:
rake rails:package (and repackage, clobber, clobber_package)
rake gem:package (and the rest...)
package their files up and dump them into pkg/rails and pkg/gem, respectively. Their clobber tasks will only remove the sub-directory under pkg/, not pkg/ itself.
rake package, rake repackage run both package tasks, while rake clobber and rake clobber_package remove the complete pkg/ directory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-154) Added package tasks for creating Rails
plugin and namespaced both the rails and gem packaging
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472263 ]
Erik Hatcher commented on SOLR-154:
-----------------------------------
Jamie's latest patch has been applied. Though I think there is a bit more to come on this.
> Added package tasks for creating Rails plugin and namespaced both the rails and gem packaging
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-154
> URL: https://issues.apache.org/jira/browse/SOLR-154
> Project: Solr
> Issue Type: Improvement
> Components: clients - ruby - flare
> Environment: Ruby and Ruby on Rails
> Reporter: Jamie Orchard-Hays
> Attachments: Rakefile.diff, Rakefile_2.diff
>
>
> Solrb's (sol.rb's?) rake file has a package:vendor task that is not generating proper rails plugin structure. Rather than just fix this, I've added a PackageTask to package up a proper Rails plugin directory structure and also build distributable packages. Included are the README, LICENSE.txt, and init.rb generated and destroyed on the fly. Also, I've namespaced the Gem PackageTask and the Rails PackageTask, so the commands:
> rake rails:package (and repackage, clobber, clobber_package)
> rake gem:package (and the rest...)
> package their files up and dump them into pkg/rails and pkg/gem, respectively. Their clobber tasks will only remove the sub-directory under pkg/, not pkg/ itself.
> rake package, rake repackage run both package tasks, while rake clobber and rake clobber_package remove the complete pkg/ directory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-154) Added package tasks for creating Rails
plugin and namespaced both the rails and gem packaging
Posted by "Jamie Orchard-Hays (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie Orchard-Hays updated SOLR-154:
------------------------------------
Attachment: Rakefile.diff
Diff of current Rakefile with my changes.
> Added package tasks for creating Rails plugin and namespaced both the rails and gem packaging
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-154
> URL: https://issues.apache.org/jira/browse/SOLR-154
> Project: Solr
> Issue Type: Improvement
> Components: clients - ruby - flare
> Environment: Ruby and Ruby on Rails
> Reporter: Jamie Orchard-Hays
> Attachments: Rakefile.diff
>
>
> Solrb's (sol.rb's?) rake file has a package:vendor task that is not generating proper rails plugin structure. Rather than just fix this, I've added a PackageTask to package up a proper Rails plugin directory structure and also build distributable packages. Included are the README, LICENSE.txt, and init.rb generated and destroyed on the fly. Also, I've names spaced the Gem PackageTask and the Rails PackageTask, so the commands:
> rake rails:package (and repackage, clobber, clobber_package)
> rake gem:package (and the rest...)
> package their files up and dump them into pkg/rails and pkg/gem, respectively. Their clobber tasks will only remove the sub-directory under pkg/, not pkg/ itself.
> rake package, rake repackage run both package tasks, while rake clobber and rake clobber_package remove the complete pkg/ directory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-154) Added package tasks for creating Rails
plugin and namespaced both the rails and gem packaging
Posted by "Jamie Orchard-Hays (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie Orchard-Hays updated SOLR-154:
------------------------------------
Attachment: Rakefile_2.diff
I've removed the old package:vendor task and replaced it with rails:install_solrb. This task depends on rails:package and takes the environment variable PLUGINS_DIR which is the path to the vendor/plugins directory to which the user wants to install solrb. If PLUGINS_DIR is not given, an exception with a message is raised.
> Added package tasks for creating Rails plugin and namespaced both the rails and gem packaging
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-154
> URL: https://issues.apache.org/jira/browse/SOLR-154
> Project: Solr
> Issue Type: Improvement
> Components: clients - ruby - flare
> Environment: Ruby and Ruby on Rails
> Reporter: Jamie Orchard-Hays
> Attachments: Rakefile.diff, Rakefile_2.diff
>
>
> Solrb's (sol.rb's?) rake file has a package:vendor task that is not generating proper rails plugin structure. Rather than just fix this, I've added a PackageTask to package up a proper Rails plugin directory structure and also build distributable packages. Included are the README, LICENSE.txt, and init.rb generated and destroyed on the fly. Also, I've namespaced the Gem PackageTask and the Rails PackageTask, so the commands:
> rake rails:package (and repackage, clobber, clobber_package)
> rake gem:package (and the rest...)
> package their files up and dump them into pkg/rails and pkg/gem, respectively. Their clobber tasks will only remove the sub-directory under pkg/, not pkg/ itself.
> rake package, rake repackage run both package tasks, while rake clobber and rake clobber_package remove the complete pkg/ directory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-154) Added package tasks for creating Rails
plugin and namespaced both the rails and gem packaging
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471818 ]
Erik Hatcher commented on SOLR-154:
-----------------------------------
I've committed this patch, but Jamie is up to a few more tweaks, so I'll close after those patches are applied.
> Added package tasks for creating Rails plugin and namespaced both the rails and gem packaging
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-154
> URL: https://issues.apache.org/jira/browse/SOLR-154
> Project: Solr
> Issue Type: Improvement
> Components: clients - ruby - flare
> Environment: Ruby and Ruby on Rails
> Reporter: Jamie Orchard-Hays
> Attachments: Rakefile.diff
>
>
> Solrb's (sol.rb's?) rake file has a package:vendor task that is not generating proper rails plugin structure. Rather than just fix this, I've added a PackageTask to package up a proper Rails plugin directory structure and also build distributable packages. Included are the README, LICENSE.txt, and init.rb generated and destroyed on the fly. Also, I've namespaced the Gem PackageTask and the Rails PackageTask, so the commands:
> rake rails:package (and repackage, clobber, clobber_package)
> rake gem:package (and the rest...)
> package their files up and dump them into pkg/rails and pkg/gem, respectively. Their clobber tasks will only remove the sub-directory under pkg/, not pkg/ itself.
> rake package, rake repackage run both package tasks, while rake clobber and rake clobber_package remove the complete pkg/ directory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-154) Added package tasks for creating Rails
plugin and namespaced both the rails and gem packaging
Posted by "Jamie Orchard-Hays (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie Orchard-Hays updated SOLR-154:
------------------------------------
Description:
Solrb's (sol.rb's?) rake file has a package:vendor task that is not generating proper rails plugin structure. Rather than just fix this, I've added a PackageTask to package up a proper Rails plugin directory structure and also build distributable packages. Included are the README, LICENSE.txt, and init.rb generated and destroyed on the fly. Also, I've namespaced the Gem PackageTask and the Rails PackageTask, so the commands:
rake rails:package (and repackage, clobber, clobber_package)
rake gem:package (and the rest...)
package their files up and dump them into pkg/rails and pkg/gem, respectively. Their clobber tasks will only remove the sub-directory under pkg/, not pkg/ itself.
rake package, rake repackage run both package tasks, while rake clobber and rake clobber_package remove the complete pkg/ directory.
was:
Solrb's (sol.rb's?) rake file has a package:vendor task that is not generating proper rails plugin structure. Rather than just fix this, I've added a PackageTask to package up a proper Rails plugin directory structure and also build distributable packages. Included are the README, LICENSE.txt, and init.rb generated and destroyed on the fly. Also, I've names spaced the Gem PackageTask and the Rails PackageTask, so the commands:
rake rails:package (and repackage, clobber, clobber_package)
rake gem:package (and the rest...)
package their files up and dump them into pkg/rails and pkg/gem, respectively. Their clobber tasks will only remove the sub-directory under pkg/, not pkg/ itself.
rake package, rake repackage run both package tasks, while rake clobber and rake clobber_package remove the complete pkg/ directory.
> Added package tasks for creating Rails plugin and namespaced both the rails and gem packaging
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-154
> URL: https://issues.apache.org/jira/browse/SOLR-154
> Project: Solr
> Issue Type: Improvement
> Components: clients - ruby - flare
> Environment: Ruby and Ruby on Rails
> Reporter: Jamie Orchard-Hays
> Attachments: Rakefile.diff
>
>
> Solrb's (sol.rb's?) rake file has a package:vendor task that is not generating proper rails plugin structure. Rather than just fix this, I've added a PackageTask to package up a proper Rails plugin directory structure and also build distributable packages. Included are the README, LICENSE.txt, and init.rb generated and destroyed on the fly. Also, I've namespaced the Gem PackageTask and the Rails PackageTask, so the commands:
> rake rails:package (and repackage, clobber, clobber_package)
> rake gem:package (and the rest...)
> package their files up and dump them into pkg/rails and pkg/gem, respectively. Their clobber tasks will only remove the sub-directory under pkg/, not pkg/ itself.
> rake package, rake repackage run both package tasks, while rake clobber and rake clobber_package remove the complete pkg/ directory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (SOLR-154) Added package tasks for creating Rails plugin and namespaced both the rails and gem packaging
Posted by Jamie Orchard-Hays <ja...@gmail.com>.
Coda, I've been thinking about this over the weekend myself. I'm not
sure that packaging this as a rails plugin makes sense either. (Flare
certainly makes sense as a plugin.)
On the other hand, you mentioned issues around just unpacking gems to
vendor/ . If that's the case, I'd rather have a reliable plugin than
a semi-reliable unpacked gem. Any more info on that?
Jamie
On Feb 12, 2007, at 11:11 AM, Coda Hale (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/SOLR-154?
> page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Coda Hale updated SOLR-154:
> ---------------------------
>
> Attachment: solrb_vendor_package.diff
>
> Here's an updated rake task for packaging solrb for use in the
> vendor directory of a Rails project.
>
> I disagree with Jamie's approach in making solrb a Rails plugin. It
> doesn't modify or extend any of the Rails libraries, nor does it
> even use libraries like ActiveSupport.
>
> Placing it in the vendor directory (and adjusting the directory
> structure so as to allow it to load with the same requires without
> messing with the load path) seems like the best option to me.
>
>> Added package tasks for creating Rails plugin and namespaced both
>> the rails and gem packaging
>> ---------------------------------------------------------------------
>> ------------------------
>>
>> Key: SOLR-154
>> URL: https://issues.apache.org/jira/browse/SOLR-154
>> Project: Solr
>> Issue Type: Improvement
>> Components: clients - ruby - flare
>> Environment: Ruby and Ruby on Rails
>> Reporter: Jamie Orchard-Hays
>> Attachments: Rakefile.diff, Rakefile_2.diff,
>> solrb_vendor_package.diff
>>
>>
>> Solrb's (sol.rb's?) rake file has a package:vendor task that is
>> not generating proper rails plugin structure. Rather than just fix
>> this, I've added a PackageTask to package up a proper Rails plugin
>> directory structure and also build distributable packages.
>> Included are the README, LICENSE.txt, and init.rb generated and
>> destroyed on the fly. Also, I've namespaced the Gem PackageTask
>> and the Rails PackageTask, so the commands:
>> rake rails:package (and repackage, clobber, clobber_package)
>> rake gem:package (and the rest...)
>> package their files up and dump them into pkg/rails and pkg/gem,
>> respectively. Their clobber tasks will only remove the sub-
>> directory under pkg/, not pkg/ itself.
>> rake package, rake repackage run both package tasks, while rake
>> clobber and rake clobber_package remove the complete pkg/ directory.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Updated: (SOLR-154) Added package tasks for creating Rails
plugin and namespaced both the rails and gem packaging
Posted by "Coda Hale (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Coda Hale updated SOLR-154:
---------------------------
Attachment: solrb_vendor_package.diff
Here's an updated rake task for packaging solrb for use in the vendor directory of a Rails project.
I disagree with Jamie's approach in making solrb a Rails plugin. It doesn't modify or extend any of the Rails libraries, nor does it even use libraries like ActiveSupport.
Placing it in the vendor directory (and adjusting the directory structure so as to allow it to load with the same requires without messing with the load path) seems like the best option to me.
> Added package tasks for creating Rails plugin and namespaced both the rails and gem packaging
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-154
> URL: https://issues.apache.org/jira/browse/SOLR-154
> Project: Solr
> Issue Type: Improvement
> Components: clients - ruby - flare
> Environment: Ruby and Ruby on Rails
> Reporter: Jamie Orchard-Hays
> Attachments: Rakefile.diff, Rakefile_2.diff, solrb_vendor_package.diff
>
>
> Solrb's (sol.rb's?) rake file has a package:vendor task that is not generating proper rails plugin structure. Rather than just fix this, I've added a PackageTask to package up a proper Rails plugin directory structure and also build distributable packages. Included are the README, LICENSE.txt, and init.rb generated and destroyed on the fly. Also, I've namespaced the Gem PackageTask and the Rails PackageTask, so the commands:
> rake rails:package (and repackage, clobber, clobber_package)
> rake gem:package (and the rest...)
> package their files up and dump them into pkg/rails and pkg/gem, respectively. Their clobber tasks will only remove the sub-directory under pkg/, not pkg/ itself.
> rake package, rake repackage run both package tasks, while rake clobber and rake clobber_package remove the complete pkg/ directory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-154) Added package tasks for creating Rails
plugin and namespaced both the rails and gem packaging
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher resolved SOLR-154.
-------------------------------
Resolution: Fixed
I've been using the Rails gem packaging feature in solr-ruby's trunk for a while now with no problems. If there are still issues with solr-ruby Rails integration feel free to reopen this issue with additional details.
> Added package tasks for creating Rails plugin and namespaced both the rails and gem packaging
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-154
> URL: https://issues.apache.org/jira/browse/SOLR-154
> Project: Solr
> Issue Type: Improvement
> Components: clients - ruby - flare
> Environment: Ruby and Ruby on Rails
> Reporter: Jamie Orchard-Hays
> Attachments: Rakefile.diff, Rakefile_2.diff, solrb_vendor_package.diff
>
>
> Solrb's (sol.rb's?) rake file has a package:vendor task that is not generating proper rails plugin structure. Rather than just fix this, I've added a PackageTask to package up a proper Rails plugin directory structure and also build distributable packages. Included are the README, LICENSE.txt, and init.rb generated and destroyed on the fly. Also, I've namespaced the Gem PackageTask and the Rails PackageTask, so the commands:
> rake rails:package (and repackage, clobber, clobber_package)
> rake gem:package (and the rest...)
> package their files up and dump them into pkg/rails and pkg/gem, respectively. Their clobber tasks will only remove the sub-directory under pkg/, not pkg/ itself.
> rake package, rake repackage run both package tasks, while rake clobber and rake clobber_package remove the complete pkg/ directory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.