You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/02 03:25:24 UTC
[GitHub] [arrow-datafusion] hntd187 opened a new pull request #1390: Be consistent with pg on real datatype
hntd187 opened a new pull request #1390:
URL: https://github.com/apache/arrow-datafusion/pull/1390
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1380 .
# Rationale for this change
Be consistent with pg
# What changes are included in this PR?
Change real datatype to map to f32 instead of f64
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] hntd187 commented on pull request #1390: Be consistent with pg on real datatype
Posted by GitBox <gi...@apache.org>.
hntd187 commented on pull request #1390:
URL: https://github.com/apache/arrow-datafusion/pull/1390#issuecomment-984853832
Of course, let me do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #1390: Be consistent with pg on real datatype
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1390:
URL: https://github.com/apache/arrow-datafusion/pull/1390#issuecomment-984319664
@hntd187 do you mind writing a quick test to guard against regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on pull request #1390: Be consistent with pg on real datatype
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on pull request #1390:
URL: https://github.com/apache/arrow-datafusion/pull/1390#issuecomment-984271778
@hntd187 thanks for your contribution.
We should make consistent with the community first.
If the datafusion just want to support the float64, i think it is not a bug.
@houqp @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1390: Be consistent with pg on real datatype
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1390:
URL: https://github.com/apache/arrow-datafusion/pull/1390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org