You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2026/05/28 05:09:41 UTC
[PR] [incubator-kie-drools-6733] Preserve insertion order in ListDataStore [incubator-kie-drools]
tkobayas opened a new pull request, #6734:
URL: https://github.com/apache/incubator-kie-drools/pull/6734
ListDataStore used IdentityHashMap which does not preserve insertion order, causing subscribe() to replay events in arbitrary order and breaking sliding window CEP behavior. Added an ArrayList<DataHandle> alongside the IdentityHashMap to maintain insertion order for iteration and replay while preserving identity-based lookup semantics.
Fixes: https://github.com/apache/incubator-kie-drools/issues/6733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6733] Preserve insertion order in ListDataStore [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #6734:
URL: https://github.com/apache/incubator-kie-drools/pull/6734#issuecomment-4572338544
yes, merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6733] Preserve insertion order in ListDataStore [incubator-kie-drools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #6734:
URL: https://github.com/apache/incubator-kie-drools/pull/6734#issuecomment-4572299345
@tkobayas Can we merge this please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6733] Preserve insertion order in ListDataStore [incubator-kie-drools]
Posted by "Rikkola (via GitHub)" <gi...@apache.org>.
Rikkola commented on PR #6734:
URL: https://github.com/apache/incubator-kie-drools/pull/6734#issuecomment-4563786397
I would myself assume that the default List keeps the order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6733] Preserve insertion order in ListDataStore [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #6734:
URL: https://github.com/apache/incubator-kie-drools/pull/6734#issuecomment-4561677282
> ListDataStore used IdentityHashMap which does not preserve insertion order, causing subscribe() to replay events in arbitrary order and breaking sliding window CEP behavior.
Note that the existing `CepTest` doesn't hit this issue, because it uses `DirectDataStream` which doesn't store data, so doesn't have this problem.
While CEP use cases expect to use `DataStream` rather than `DataStore`, users would still expect "List" named class to preserve insertion order. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6733] Preserve insertion order in ListDataStore [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas merged PR #6734:
URL: https://github.com/apache/incubator-kie-drools/pull/6734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org