You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Ed Kohlwey (Created) (JIRA)" <ji...@apache.org> on 2011/10/27 22:06:32 UTC
[jira] [Created] (MESOS-50) Use of pushd and popd in makefile based
on sh (not bash)
Use of pushd and popd in makefile based on sh (not bash)
--------------------------------------------------------
Key: MESOS-50
URL: https://issues.apache.org/jira/browse/MESOS-50
Project: Mesos
Issue Type: Bug
Components: build
Environment: Ubuntu Lucid
Reporter: Ed Kohlwey
The mesos build scripts use pushd and popd. These commands are particular to bash.
For whatever reason OSX and possibly other unixes implement them in sh; Ubuntu does not (and it probably shouldn't).
The build shell should probably be switched to bash.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MESOS-50) Use of pushd and popd in makefile
based on sh (not bash)
Posted by "Andy Konwinski (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Konwinski reassigned MESOS-50:
-----------------------------------
Assignee: Ed Kohlwey
> Use of pushd and popd in makefile based on sh (not bash)
> --------------------------------------------------------
>
> Key: MESOS-50
> URL: https://issues.apache.org/jira/browse/MESOS-50
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Ubuntu Lucid
> Reporter: Ed Kohlwey
> Assignee: Ed Kohlwey
> Priority: Blocker
> Attachments: MESOS-50.patch, MESOS-50.patch
>
>
> The mesos build scripts use pushd and popd. These commands are particular to bash.
> For whatever reason OSX and possibly other unixes implement them in sh; Ubuntu does not (and it probably shouldn't).
> The build shell should probably be switched to bash.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MESOS-50) Use of pushd and popd in makefile based
on sh (not bash)
Posted by "Ed Kohlwey (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ed Kohlwey updated MESOS-50:
----------------------------
Attachment: MESOS-50.patch
Simple patch to change the shell used by make
> Use of pushd and popd in makefile based on sh (not bash)
> --------------------------------------------------------
>
> Key: MESOS-50
> URL: https://issues.apache.org/jira/browse/MESOS-50
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Ubuntu Lucid
> Reporter: Ed Kohlwey
> Attachments: MESOS-50.patch
>
>
> The mesos build scripts use pushd and popd. These commands are particular to bash.
> For whatever reason OSX and possibly other unixes implement them in sh; Ubuntu does not (and it probably shouldn't).
> The build shell should probably be switched to bash.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-50) Use of pushd and popd in makefile
based on sh (not bash)
Posted by "Andy Konwinski (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137577#comment-13137577 ]
Andy Konwinski commented on MESOS-50:
-------------------------------------
An alternative would be replace any instances of pushd and popd with uses of cd.
> Use of pushd and popd in makefile based on sh (not bash)
> --------------------------------------------------------
>
> Key: MESOS-50
> URL: https://issues.apache.org/jira/browse/MESOS-50
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Ubuntu Lucid
> Reporter: Ed Kohlwey
> Attachments: MESOS-50.patch
>
>
> The mesos build scripts use pushd and popd. These commands are particular to bash.
> For whatever reason OSX and possibly other unixes implement them in sh; Ubuntu does not (and it probably shouldn't).
> The build shell should probably be switched to bash.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MESOS-50) Use of pushd and popd in makefile
based on sh (not bash)
Posted by "Andy Konwinski (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Konwinski resolved MESOS-50.
---------------------------------
Resolution: Fixed
I've just committed this. Thanks Ed!
> Use of pushd and popd in makefile based on sh (not bash)
> --------------------------------------------------------
>
> Key: MESOS-50
> URL: https://issues.apache.org/jira/browse/MESOS-50
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Ubuntu Lucid
> Reporter: Ed Kohlwey
> Assignee: Ed Kohlwey
> Priority: Blocker
> Attachments: MESOS-50.patch, MESOS-50.patch
>
>
> The mesos build scripts use pushd and popd. These commands are particular to bash.
> For whatever reason OSX and possibly other unixes implement them in sh; Ubuntu does not (and it probably shouldn't).
> The build shell should probably be switched to bash.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MESOS-50) Use of pushd and popd in makefile based
on sh (not bash)
Posted by "Andy Konwinski (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Konwinski updated MESOS-50:
--------------------------------
Priority: Blocker (was: Major)
> Use of pushd and popd in makefile based on sh (not bash)
> --------------------------------------------------------
>
> Key: MESOS-50
> URL: https://issues.apache.org/jira/browse/MESOS-50
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Ubuntu Lucid
> Reporter: Ed Kohlwey
> Priority: Blocker
> Attachments: MESOS-50.patch, MESOS-50.patch
>
>
> The mesos build scripts use pushd and popd. These commands are particular to bash.
> For whatever reason OSX and possibly other unixes implement them in sh; Ubuntu does not (and it probably shouldn't).
> The build shell should probably be switched to bash.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MESOS-50) Use of pushd and popd in makefile based
on sh (not bash)
Posted by "Ed Kohlwey (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ed Kohlwey updated MESOS-50:
----------------------------
Attachment: MESOS-50.patch
This one changes the value in both Makefile.in's
> Use of pushd and popd in makefile based on sh (not bash)
> --------------------------------------------------------
>
> Key: MESOS-50
> URL: https://issues.apache.org/jira/browse/MESOS-50
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Ubuntu Lucid
> Reporter: Ed Kohlwey
> Attachments: MESOS-50.patch, MESOS-50.patch
>
>
> The mesos build scripts use pushd and popd. These commands are particular to bash.
> For whatever reason OSX and possibly other unixes implement them in sh; Ubuntu does not (and it probably shouldn't).
> The build shell should probably be switched to bash.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-50) Use of pushd and popd in makefile
based on sh (not bash)
Posted by "Ed Kohlwey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137661#comment-13137661 ]
Ed Kohlwey commented on MESOS-50:
---------------------------------
IMHO bash may be a better long-term solution anyways; most people use bash and so its a more natural shell to program in (at least for me). Also, preserving the use of pushd and popd is a little more maintainable; someone can modify the script without thinking about where the directory was prior to whatever operation they needed to cd for.
> Use of pushd and popd in makefile based on sh (not bash)
> --------------------------------------------------------
>
> Key: MESOS-50
> URL: https://issues.apache.org/jira/browse/MESOS-50
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Ubuntu Lucid
> Reporter: Ed Kohlwey
> Attachments: MESOS-50.patch, MESOS-50.patch
>
>
> The mesos build scripts use pushd and popd. These commands are particular to bash.
> For whatever reason OSX and possibly other unixes implement them in sh; Ubuntu does not (and it probably shouldn't).
> The build shell should probably be switched to bash.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira