[jira] [Commented] (YARN-2301) Improve yarn container command

["Jian He (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216945#comment-14216945 ] 

Jian He commented on YARN-2301:
-------------------------------

thanks [~Naganarasimha], looked at the latest patch, some comments:
- we can just use containerReport.getFinishTime(), as it internally is checking “>0” already.
{code}
          (containerReport.getFinishTime() == 0 ? "N/A" : Times
          .format(containerReport.getFinishTime())),   
{code}
- the scheme could be https also, we should use WebAppUtils#getHttpSchemePrefix
{code}
"http://"
              + WebAppUtils.getRunningLogURL(container.getNodeHttpAddress(),
                  ConverterUtils.toString(containerId), user);
{code}

> Improve yarn container command
> ------------------------------
>
>                 Key: YARN-2301
>                 URL: https://issues.apache.org/jira/browse/YARN-2301
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Jian He
>            Assignee: Naganarasimha G R
>              Labels: usability
>         Attachments: YARN-2301.01.patch, YARN-2301.03.patch, YARN-2303.patch
>
>
> While running yarn container -list <Application Attempt ID> command, some observations:
> 1) the scheme (e.g. http/https  ) before LOG-URL is missing
> 2) the start-time is printed as milli seconds (e.g. 1405540544844). Better to print as time format.
> 3) finish-time is 0 if container is not yet finished. May be "N/A"
> 4) May have an option to run as yarn container -list <appId> OR  yarn application -list-containers <appId> also.  
> As attempt Id is not shown on console, this is easier for user to just copy the appId and run it, may  also be useful for container-preserving AM restart. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)