You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/28 15:58:44 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #11091: chore: use antd `Popover` instead of `react-bootstrap`
mistercrunch opened a new pull request #11091:
URL: https://github.com/apache/incubator-superset/pull/11091
`react-bootstrap`'s Popover doesn't work with `emotion`'s styling and theming and has created some regressions that are are to predict and/or test for. For instance it broke the "Filter Box" filter control and the `SpatialControl` in ways that unit tests can't get ahead of.
The issue is around some funk that `react-bootstrap` does that prevents the theme context to trickle down.
Knowing this, the solution is to accelerate getting rid of `react-bootstrap`, especially the component that have JS in them like modals, popovers, tooltips.
This PR is incomplete, I ran in some issues:
- `antd` wrapping is a bit tricky, not sure how to reuse their interfaces or just pass props down without TS complaining
- `react-storybook` isn't picking up the component
- unclear how to get `enzyme` to `.find()` the popover's content, found a hack by using `instance()` and calling `renderPopover` but unclear if it's the best/right approach
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch closed pull request #11091: chore: use antd `Popover` instead of `react-bootstrap`
Posted by GitBox <gi...@apache.org>.
mistercrunch closed pull request #11091:
URL: https://github.com/apache/incubator-superset/pull/11091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org