You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2010/04/24 13:09:12 UTC

svn commit: r937623 - /subversion/trunk/subversion/libsvn_delta/svndiff.c

Author: danielsh
Date: Sat Apr 24 11:09:12 2010
New Revision: 937623

URL: http://svn.apache.org/viewvc?rev=937623&view=rev
Log:
Address a compiler warning.

* subversion/libsvn_delta/svndiff.c
  (window_handler):
    Use unsigned chars instead of (implicit-signedness) chars to compute the
    "instruction selector" bits.

Modified:
    subversion/trunk/subversion/libsvn_delta/svndiff.c

Modified: subversion/trunk/subversion/libsvn_delta/svndiff.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_delta/svndiff.c?rev=937623&r1=937622&r2=937623&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_delta/svndiff.c (original)
+++ subversion/trunk/subversion/libsvn_delta/svndiff.c Sat Apr 24 11:09:12 2010
@@ -183,7 +183,7 @@ window_handler(svn_txdelta_window_t *win
   svn_stringbuf_t *i1 = svn_stringbuf_create("", pool);
   svn_stringbuf_t *header = svn_stringbuf_create("", pool);
   const svn_string_t *newdata;
-  char ibuf[MAX_INSTRUCTION_LEN], *ip;
+  unsigned char ibuf[MAX_INSTRUCTION_LEN], *ip;
   const svn_txdelta_op_t *op;
   apr_size_t len;
 
@@ -225,9 +225,9 @@ window_handler(svn_txdelta_window_t *win
       ip = ibuf;
       switch (op->action_code)
         {
-        case svn_txdelta_source: *ip = (char)0; break;
-        case svn_txdelta_target: *ip = (char)(0x1 << 6); break;
-        case svn_txdelta_new:    *ip = (char)(0x2 << 6); break;
+        case svn_txdelta_source: *ip = 0; break;
+        case svn_txdelta_target: *ip = (0x1 << 6); break;
+        case svn_txdelta_new:    *ip = (0x2 << 6); break;
         }
       if (op->length >> 6 == 0)
         *ip++ |= op->length;