You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2016/11/11 17:32:59 UTC
[jira] [Commented] (AMBARI-18863) Upgrade Type Is Incorrectly
Quoted When Serialized
[ https://issues.apache.org/jira/browse/AMBARI-18863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657604#comment-15657604 ]
Hadoop QA commented on AMBARI-18863:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12838569/AMBARI-18863.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in ambari-server:
org.apache.ambari.server.controller.metrics.JMXPropertyProviderTest
org.apache.ambari.server.controller.internal.UpgradeResourceProviderTest
org.apache.ambari.server.state.ServicePropertiesTest
Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9238//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9238//console
This message is automatically generated.
> Upgrade Type Is Incorrectly Quoted When Serialized
> --------------------------------------------------
>
> Key: AMBARI-18863
> URL: https://issues.apache.org/jira/browse/AMBARI-18863
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 2.5.0
> Reporter: Jonathan Hurley
> Assignee: Jonathan Hurley
> Priority: Blocker
> Fix For: 2.5.0
>
> Attachments: AMBARI-18863.patch
>
>
> When creating an upgrade, the serialized {{UpgradeType}} is quoted causing problems with the python code:
> {code}
> "commandParams": {
> "upgrade_direction": "upgrade",
> "service_package_folder": "common-services/ZOOKEEPER/3.4.5/package",
> "script": "scripts/zookeeper_server.py",
> "hooks_folder": "HDP/2.0.6/hooks",
> "upgrade_type": "\"host_ordered_upgrade\"",
> {code}
> The problem is the Gson, when converting the enum into a String, is giving back a JSON-ready String which includes the quotes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)