You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2018/04/27 13:40:31 UTC

[GitHub] oschaaf commented on issue #1552: Honor assume yes when installing dependencies

oschaaf commented on issue #1552: Honor assume yes when installing dependencies
URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1552#issuecomment-384973046
 
 
   Code change looks good, and in terms of function it looks like this makes a lot of sense. 
   I have to dive in some more to do a proper review, I'll try to do that in the coming days.
   One thing I wonder about is that in CI the unattended mode seems to work as-is, 
   but that also has `--devel` specified:
   https://github.com/apache/incubator-pagespeed-ngx/blob/master/.travis.yml#L23

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services