You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gu...@apache.org on 2019/06/06 18:30:40 UTC
[kafka] branch trunk updated: HOTFIX: Close unused
ColumnFamilyHandle (#6893)
This is an automated email from the ASF dual-hosted git repository.
guozhang pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 30adf2a HOTFIX: Close unused ColumnFamilyHandle (#6893)
30adf2a is described below
commit 30adf2a096a7c879497b435b1704620e86d9e71e
Author: A. Sophie Blee-Goldman <so...@confluent.io>
AuthorDate: Thu Jun 6 11:29:39 2019 -0700
HOTFIX: Close unused ColumnFamilyHandle (#6893)
In RocksDBTimestampedStore#openRocksDB we try to open a db with two column families. If this succeeds but the first column family is empty (db.newIterator.seekToFirst.isValid() == false) we never actually close its ColumnFamilyHandle
Reviewers: Matthias J. Sax <ma...@confluent.io>, Guozhang Wang <wa...@gmail.com>
---
.../apache/kafka/streams/state/internals/RocksDBTimestampedStore.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java
index 05db0ea..74f0919 100644
--- a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java
+++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java
@@ -81,6 +81,7 @@ public class RocksDBTimestampedStore extends RocksDBStore implements Timestamped
} else {
log.info("Opening store {} in regular mode", name);
dbAccessor = new SingleColumnFamilyAccessor(columnFamilies.get(1));
+ noTimestampColumnFamily.close();
}
noTimestampsIter.close();
} catch (final RocksDBException e) {