You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/16 10:32:43 UTC
[GitHub] [incubator-nuttx-apps] Weizihan opened a new pull request, #1281: apps: Fix the bug that didn't initialize structure
Weizihan opened a new pull request, #1281:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1281
Signed-off-by: weizihan <we...@xiaomi.com>
## Summary
netutils/usrsock_rpmsg/usrsock_rpmsg_client.c
Fix the bug that didn't initialize structure
## Impact
usrsock_rpmsg_client.c Calling memset to initialize pfd
## Testing
passed vela CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1281: apps: Fix the bug that didn't initialize structure
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1281:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1281#discussion_r946647559
##########
netutils/usrsock_rpmsg/usrsock_rpmsg_client.c:
##########
@@ -267,6 +267,7 @@ int main(int argc, char *argv[])
/* Wait the packet ready */
+ memset(&pfd, 0, sizeof(struct pollfd));
Review Comment:
Can FD_ZERO be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1281: apps: Fix the bug that didn't initialize structure
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1281:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1281#discussion_r946662842
##########
netutils/usrsock_rpmsg/usrsock_rpmsg_client.c:
##########
@@ -267,6 +267,7 @@ int main(int argc, char *argv[])
/* Wait the packet ready */
+ memset(&pfd, 0, sizeof(struct pollfd));
Review Comment:
FD_ZERO is just for select and fd_set, not poll and pollfd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1281: apps: Fix the bug that didn't initialize structure
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1281:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org