You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Tim Thorpe <tt...@ca.ibm.com> on 2016/11/29 19:00:57 UTC
Review Request 54171: AMBARI-19018 - Services should be able to
specify their own resources subdirs for sync'ing to agents
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54171/
-----------------------------------------------------------
Review request for Ambari, Di Li, Jayush Luniya, and Sumit Mohanty.
Bugs: AMBARI-19018
https://issues.apache.org/jira/browse/AMBARI-19018
Repository: ambari
Description
-------
A component should be able to specify a custom folder to sync to the agents in the metainfo.xml.
For example:
<component>
<name>METRICS_GRAFANA</name>
<displayName>Grafana</displayName>
<category>MASTER</category>
<customFolder>dashboards</customFolder>
<commandScript>
<script>scripts/metrics_grafana.py</script>
This will sync the resources/dashboards directory to the agents if the directory exists on the server.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 770484d
ambari-agent/src/main/python/ambari_agent/FileCache.py 83ac373
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 2be6e1a
ambari-agent/src/test/python/ambari_agent/TestFileCache.py fbefc2b
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 29737ee
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java ac9e405
ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 1e494b4
ambari-server/src/main/python/ambari_server/serverConfiguration.py 9596e0d
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 43a4320
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 0fdaa46
ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java 6773176
ambari-server/src/test/python/TestMpacks.py ba37856
ambari-server/src/test/resources/dashboards/README.txt PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/metainfo.xml f4195a8
Diff: https://reviews.apache.org/r/54171/diff/
Testing
-------
ambari-server:
mvn clean test -DskipPythonTests -Dtest=AmbariManagementControllerTest
mvn clean test
ambari-agent:
mvn clean test
Thanks,
Tim Thorpe
Re: Review Request 54171: AMBARI-19018 - Services should be able to
specify their own resources subdirs for sync'ing to agents
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54171/#review157321
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On Nov. 29, 2016, 7 p.m., Tim Thorpe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54171/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 7 p.m.)
>
>
> Review request for Ambari, Di Li, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19018
> https://issues.apache.org/jira/browse/AMBARI-19018
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A component should be able to specify a custom folder to sync to the agents in the metainfo.xml.
>
> For example:
>
> <component>
> <name>METRICS_GRAFANA</name>
> <displayName>Grafana</displayName>
> <category>MASTER</category>
> <customFolder>dashboards</customFolder>
> <commandScript>
> <script>scripts/metrics_grafana.py</script>
>
> This will sync the resources/dashboards directory to the agents if the directory exists on the server.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 770484d
> ambari-agent/src/main/python/ambari_agent/FileCache.py 83ac373
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 2be6e1a
> ambari-agent/src/test/python/ambari_agent/TestFileCache.py fbefc2b
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 29737ee
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java ac9e405
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 1e494b4
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 9596e0d
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 43a4320
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 0fdaa46
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java 6773176
> ambari-server/src/test/python/TestMpacks.py ba37856
> ambari-server/src/test/resources/dashboards/README.txt PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/metainfo.xml f4195a8
>
> Diff: https://reviews.apache.org/r/54171/diff/
>
>
> Testing
> -------
>
> ambari-server:
>
> mvn clean test -DskipPythonTests -Dtest=AmbariManagementControllerTest
> mvn clean test
>
> ambari-agent:
>
> mvn clean test
>
>
> Thanks,
>
> Tim Thorpe
>
>