You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/06 17:57:53 UTC
[GitHub] [airflow] apogre opened a new pull request #15233: Update sqs.py
apogre opened a new pull request #15233:
URL: https://github.com/apache/airflow/pull/15233
Ability to filter messages by their attribute names using MessageAttributeNames filter.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang edited a comment on pull request #15233: Update sqs.py
Posted by GitBox <gi...@apache.org>.
xinbinhuang edited a comment on pull request #15233:
URL: https://github.com/apache/airflow/pull/15233#issuecomment-818435020
@apogre Can you also add some tests and fix the CI, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15233: Update sqs.py
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15233:
URL: https://github.com/apache/airflow/pull/15233#issuecomment-814370762
[The Workflow run](https://github.com/apache/airflow/actions/runs/723606485) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #15233: Allow SQSSensor to filter messages by their attribute names
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #15233:
URL: https://github.com/apache/airflow/pull/15233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on a change in pull request #15233: Update sqs.py
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #15233:
URL: https://github.com/apache/airflow/pull/15233#discussion_r612128944
##########
File path: airflow/providers/amazon/aws/sensors/sqs.py
##########
@@ -50,13 +52,15 @@ def __init__(
aws_conn_id: str = 'aws_default',
max_messages: int = 5,
wait_time_seconds: int = 1,
+ message_attribute_names: list = ['.*']
Review comment:
Let's push it under the constructor
```suggestion
message_attribute_names: Optional[List[str]] = None
```
And then within the constructor
```python
self.message_attribute_names = ['.*'] if message_attribute_names is None else message_attribute_names
```
The reason being python has gotcha around [mutable default arguments](https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments)
##########
File path: airflow/providers/amazon/aws/sensors/sqs.py
##########
@@ -38,6 +38,8 @@ class SQSSensor(BaseSensorOperator):
:type max_messages: int
:param wait_time_seconds: The time in seconds to wait for receiving messages (default: 1 second)
:type wait_time_seconds: int
+ :param message_attribute_names: The message attribute names to filter receiving messages (default: All Messages)
+ :type wait_time_seconds: list
Review comment:
```suggestion
:type message_attribute_names: list
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15233: Update sqs.py
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15233:
URL: https://github.com/apache/airflow/pull/15233#issuecomment-814370886
[The Workflow run](https://github.com/apache/airflow/actions/runs/723609114) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15233: Update sqs.py
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15233:
URL: https://github.com/apache/airflow/pull/15233#issuecomment-814321930
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15233: Allow SQSSensor to filter messages by their attribute names
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15233:
URL: https://github.com/apache/airflow/pull/15233#issuecomment-890259919
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on pull request #15233: Update sqs.py
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on pull request #15233:
URL: https://github.com/apache/airflow/pull/15233#issuecomment-818437152
As I understand, `MessageAttributeNames` doesn't really help filter messages. Rather it will only return the specified attributes when receiving messages. So if a message does not have the required attributes, it will still return, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on pull request #15233: Update sqs.py
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on pull request #15233:
URL: https://github.com/apache/airflow/pull/15233#issuecomment-818435020
@apogre Can you also add some tests thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #15233: Allow SQSSensor to filter messages by their attribute names
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #15233:
URL: https://github.com/apache/airflow/pull/15233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org