You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/23 10:32:38 UTC
[GitHub] [camel-quarkus] Jeansen opened a new pull request #1567: RabbitMQ native extension
Jeansen opened a new pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567
Promote RabbitMQ to natvive, see #1531
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] Jeansen commented on a change in pull request #1567: RabbitMQ native extension
Posted by GitBox <gi...@apache.org>.
Jeansen commented on a change in pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567#discussion_r475253099
##########
File path: tooling/scripts/test-categories.yaml
##########
@@ -75,6 +75,7 @@ memoryhog-xml:
- rest-binding-mode-xml
- xml
messaging:
+ - rabbitmq
Review comment:
Ok. I've corrected hat one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1567: RabbitMQ native extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567#issuecomment-679048035
> But when run from the main folder, I get the following:
Yes, that's what I meant. Sorry that I have not made it clear straight away.
> ```
> Changes not staged for commit:
> (use "git add <file>..." to update what will be committed)
> (use "git restore <file>..." to discard changes in working directory)
> modified: docs/modules/ROOT/pages/reference/components.adoc
> modified: docs/modules/ROOT/pages/reference/extensions/rabbitmq.adoc
> modified: docs/modules/ROOT/pages/reference/index.adoc
> modified: extensions/rabbitmq/deployment/src/main/java/org/apache/camel/quarkus/component/rabbitmq/deployment/RabbitmqProcessor.java
> modified: extensions/rabbitmq/runtime/src/main/resources/META-INF/quarkus-extension.yaml
> modified: integration-tests/rabbitmq/pom.xml
All of the above definitely need to be amended.
But the changes in `extensions-jvm/apns` seem strange. Please ignore them.
> Untracked files:
> (use "git add <file>..." to include in what will be committed)
> extensions-jvm/apns/deployment/src/main/java/org/apache/camel/quarkus/component/rabbitmq/
> extensions-jvm/apns/integration-test/src/main/java/org/apache/camel/quarkus/component/rabbitmq/
> extensions-jvm/apns/integration-test/src/test/java/org/apache/camel/quarkus/component/apns/it/RabbitmqTest.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1567: RabbitMQ native extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567#discussion_r475211973
##########
File path: tooling/scripts/test-categories.yaml
##########
@@ -75,6 +75,7 @@ memoryhog-xml:
- rest-binding-mode-xml
- xml
messaging:
+ - rabbitmq
Review comment:
Could you please keep alphabetic ordering under messaging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] Jeansen commented on pull request #1567: RabbitMQ native extension
Posted by GitBox <gi...@apache.org>.
Jeansen commented on pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567#issuecomment-678811550
After rebasing, local test still passes ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] Jeansen commented on pull request #1567: RabbitMQ native extension
Posted by GitBox <gi...@apache.org>.
Jeansen commented on pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567#issuecomment-678937623
> The CI says you should build locally and amend the reformatted Java file and the generated AsciiDoc files.
When I run ` mvn clean install -DskipTests -Pformat` from within my integration test, I do not get any errors or additional files to add.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1567: RabbitMQ native extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567#issuecomment-678827537
The CI says you should build locally and amend the reformatted Java file and the generated AsciiDoc files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] Jeansen edited a comment on pull request #1567: RabbitMQ native extension
Posted by GitBox <gi...@apache.org>.
Jeansen edited a comment on pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567#issuecomment-678937623
> The CI says you should build locally and amend the reformatted Java file and the generated AsciiDoc files.
When I run ` mvn clean install -DskipTests -Pformat` from within my integration test, I do not get any errors or additional files to add.
But when run from the main folder, I get the following:
```
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: docs/modules/ROOT/pages/reference/components.adoc
modified: docs/modules/ROOT/pages/reference/extensions/rabbitmq.adoc
modified: docs/modules/ROOT/pages/reference/index.adoc
modified: extensions/rabbitmq/deployment/src/main/java/org/apache/camel/quarkus/component/rabbitmq/deployment/RabbitmqProcessor.java
modified: extensions/rabbitmq/runtime/src/main/resources/META-INF/quarkus-extension.yaml
modified: integration-tests/rabbitmq/pom.xml
Untracked files:
(use "git add <file>..." to include in what will be committed)
extensions-jvm/apns/deployment/src/main/java/org/apache/camel/quarkus/component/rabbitmq/
extensions-jvm/apns/integration-test/src/main/java/org/apache/camel/quarkus/component/rabbitmq/
extensions-jvm/apns/integration-test/src/test/java/org/apache/camel/quarkus/component/apns/it/RabbitmqTest.java
no changes added to commit (use "git add" and/or "git commit -a")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] Jeansen commented on pull request #1567: RabbitMQ native extension
Posted by GitBox <gi...@apache.org>.
Jeansen commented on pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567#issuecomment-679060551
> > But when run from the main folder, I get the following:
>
> Yes, that's what I meant. Sorry that I have not made it clear straight away.
Not a problem. I'ts a big project. I've amended the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1567: RabbitMQ native extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567#issuecomment-679108083
Great work @Jeansen , thanks a lot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #1567: RabbitMQ native extension
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] Jeansen commented on a change in pull request #1567: RabbitMQ native extension
Posted by GitBox <gi...@apache.org>.
Jeansen commented on a change in pull request #1567:
URL: https://github.com/apache/camel-quarkus/pull/1567#discussion_r475253099
##########
File path: tooling/scripts/test-categories.yaml
##########
@@ -75,6 +75,7 @@ memoryhog-xml:
- rest-binding-mode-xml
- xml
messaging:
+ - rabbitmq
Review comment:
Ok. I've corrected that one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org