You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/02/06 14:22:44 UTC

[GitHub] [guacamole-server] myjimmy opened a new pull request #255: GUACAMOLE-947: Fix the initialization issue of CLIPRDR_FORMAT_LIST object

myjimmy opened a new pull request #255: GUACAMOLE-947: Fix the initialization issue of CLIPRDR_FORMAT_LIST object
URL: https://github.com/apache/guacamole-server/pull/255
 
 
   I have fixed GUACAMOLE-947 issue registered by me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [guacamole-server] mike-jumper commented on issue #255: GUACAMOLE-947: Fix the initialization issue of CLIPRDR_FORMAT_LIST object

Posted by GitBox <gi...@apache.org>.

mike-jumper commented on issue #255: GUACAMOLE-947: Fix the initialization issue of CLIPRDR_FORMAT_LIST object
URL: https://github.com/apache/guacamole-server/pull/255#issuecomment-583070859

The `msgType` field of the Format List PDU _does_ need to be set to `CLIPRDR_FORMAT_LIST` according to Microsoft's documentation for CLIPRDR; the relevant message can't be identified otherwise.

The reason this wasn't done here was that the `msgType` member of FreeRDP's `CLIPRDR_FORMAT_LIST` structure was ignored by FreeRDP, with their internal handling always sending `CLIPRDR_FORMAT_LIST` regardless of what `msgType` was set to. Our implementation followed the pattern used by xfreerdp and omitted setting that property, relying instead on the known behavior of FreeRDP's functions for sending this PDU.

It looks like the above has changed within FreeRDP's git master. This warning will not occur against 2.0.0-rc4 and earlier. It will occur for the xfreerdp client, as well, which appears to not have been updated to set `msgType`.

Since it should be safe to set this property for older versions of FreeRDP (it will just be overwritten), I believe this change should be fine, though it's annoying that library function behavior would change like this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [guacamole-server] necouchman commented on issue #255: GUACAMOLE-947: Fix the initialization issue of CLIPRDR_FORMAT_LIST object

Posted by GitBox <gi...@apache.org>.

necouchman commented on issue #255: GUACAMOLE-947: Fix the initialization issue of CLIPRDR_FORMAT_LIST object
URL: https://github.com/apache/guacamole-server/pull/255#issuecomment-582993664
 
 
   @myjimmy: Very nice - thank you for the contribution!  One question from me - have you verified that this change is backward-compatible with other Windows RDP versions/servers, such that adding it does not break compatibility?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [guacamole-server] necouchman merged pull request #255: GUACAMOLE-947: Fix the initialization issue of CLIPRDR_FORMAT_LIST object

Posted by GitBox <gi...@apache.org>.

necouchman merged pull request #255: GUACAMOLE-947: Fix the initialization issue of CLIPRDR_FORMAT_LIST object
URL: https://github.com/apache/guacamole-server/pull/255
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services