You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by kkhatua <gi...@git.apache.org> on 2015/05/06 18:39:39 UTC
[GitHub] drill pull request: DRILL-2961: Throw SQLException when attempting...
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/71
DRILL-2961: Throw SQLException when attempting to set query timeout
Statement.setQueryTimeout(int seconds) is a No-Op, leading the user to
believe that a timeout has been set. This provides the correct response
(SQLException for 'method not supported')
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkhatua/drill master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit 1d3ffe84f3237d614b524702e89be8cce1509931
Author: Kunal Khatua <kk...@maprtech.com>
Date: 2015-05-06T16:37:56Z
DRILL-2961: Throw SQLException when attempting to set query timeout
Statement.setQueryTimeout(int seconds) is a No-Op, leading the user to
believe that a timeout has been set. This provides the correct response
(SQLException for 'method not supported')
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2961: Throw SQLException when attempting...
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2961: Throw SQLException when attempting...
Posted by dsbos <gi...@git.apache.org>.
Github user dsbos commented on the pull request:
https://github.com/apache/drill/pull/71#issuecomment-143908786
@kkhatua, Can you close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2961: Throw SQLException when attempting...
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the pull request:
https://github.com/apache/drill/pull/71#issuecomment-143909578
Closing pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2961: Throw SQLException when attempting...
Posted by dsbos <gi...@git.apache.org>.
Github user dsbos commented on the pull request:
https://github.com/apache/drill/pull/71#issuecomment-143905747
This has been merged (commits 1dcf6cfb0d52435bcc7d1f4eada48fc0ce366dc4 and a3ec52a721860a966dfa351f719458a200b27cbf).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] drill pull request: DRILL-2961: Throw SQLException when attempting...
Posted by Chris Westin <ch...@gmail.com>.
The github apache account is a read-only mirror of http://git.apache.org/ /
https://git-wip-us.apache.org/repos/asf?p=drill.git
(see http://www.apache.org/dev/git.html). So unfortunately, we don't get to
use the nice github pull mechanics.
Instead, you need to submit a patch for review on the Apache review board
at reviews.apache.org. Then it can be reviewed and a committer can merge it
if it passes muster. The whole process is described here:
http://drill.apache.org/docs/apache-drill-contribution-guidelines/ .
On Wed, May 6, 2015 at 9:39 AM, kkhatua <gi...@git.apache.org> wrote:
> GitHub user kkhatua opened a pull request:
>
> https://github.com/apache/drill/pull/71
>
> DRILL-2961: Throw SQLException when attempting to set query timeout
>
> Statement.setQueryTimeout(int seconds) is a No-Op, leading the user to
> believe that a timeout has been set. This provides the correct response
> (SQLException for 'method not supported')
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/kkhatua/drill master
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/drill/pull/71.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #71
>
> ----
> commit 1d3ffe84f3237d614b524702e89be8cce1509931
> Author: Kunal Khatua <kk...@maprtech.com>
> Date: 2015-05-06T16:37:56Z
>
> DRILL-2961: Throw SQLException when attempting to set query timeout
>
> Statement.setQueryTimeout(int seconds) is a No-Op, leading the user to
> believe that a timeout has been set. This provides the correct response
> (SQLException for 'method not supported')
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>