[GitHub] activemq-artemis pull request #1955: Artemis 1748

[lulf <gi...@git.apache.org>]

GitHub user lulf opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1955

    Artemis 1748

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lulf/activemq-artemis ARTEMIS-1748

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1955.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1955
    
----
commit 96b40501be2b2e2c1efdba05a43f925b51a4b346
Author: Ulf Lilleengen <lu...@...>
Date:   2018-03-15T12:06:53Z

    Add close listeners

commit b4c2d8511f7b8db04aa2210f2120a9262868ee4b
Author: Ulf Lilleengen <lu...@...>
Date:   2018-03-15T13:02:40Z

    Use fail on connection closed

----


---

[GitHub] activemq-artemis issue #1955: Artemis 1748

[jbertram <gi...@git.apache.org>]

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1955
  
    I don't mean to be pedantic, but can you squash these and add the JIRA to the final commit message?  Also, I know there wasn't a test added on ARTEMIS-1050, but would it be possible to add a test here?  I'm always concerned about regressions when I see changes without a test.


---

[GitHub] activemq-artemis issue #1955: Artemis 1748

[lulf <gi...@git.apache.org>]

Github user lulf commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1955
  
    @jbertram Added/extended the connection tests. I think CI is failing on something unrelated but please check.


---

[GitHub] activemq-artemis pull request #1955: Artemis 1748

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1955


---